Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: check error type before logging #3697

Merged
merged 3 commits into from
Apr 12, 2024

Conversation

sunng87
Copy link
Member

@sunng87 sunng87 commented Apr 11, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

This patch enforces check for should_log_error to all user-facing APIs, to prevent misinformation while operating greptimedb.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@sunng87 sunng87 requested a review from a team as a code owner April 11, 2024 21:23
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Apr 11, 2024
@sunng87 sunng87 requested a review from shuiyisong April 11, 2024 21:37
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 26.31579% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 85.23%. Comparing base (02f806f) to head (da34860).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3697      +/-   ##
==========================================
- Coverage   85.57%   85.23%   -0.34%     
==========================================
  Files         957      957              
  Lines      159226   159236      +10     
==========================================
- Hits       136258   135731     -527     
- Misses      22968    23505     +537     

@tisonkun tisonkun added this pull request to the merge queue Apr 12, 2024
Merged via the queue into GreptimeTeam:main with commit 544c4a7 Apr 12, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants