fix: cli export "create table" with quoted names

[dimbtp]

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

close #3681

What's changed and what's your intention?

Solve the problem that running cli export with --target create-table fails when the catalog/schema/table names contain . (e.g. a.b.c).

Checklist

• I have written the necessary rustdoc comments.
• I have added the necessary unit tests and integration tests.
• This PR does not require documentation updates.

[codecov]

Codecov Report

Attention: Patch coverage is 98.64865% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 85.20%. Comparing base (aab7367) to head (c3b4fc4).
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3684      +/-   ##
==========================================
+ Coverage   85.17%   85.20%   +0.02%     
==========================================
  Files         955      957       +2     
  Lines      158994   159226     +232     
==========================================
+ Hits       135431   135673     +242     
+ Misses      23563    23553      -10     

[tisonkun]

Thank you!

[killme2008]

Good job! Could you add a test for it?

[dimbtp]

Good job! Could you add a test for it?

@killme2008
I did some investigations and tried following 2 approaches:

First use std::process::Command::new to spawn two threads, one is standalone server and another is cli export to test the function.
Then I plan to create target database and table with quoted name (e.g. test-export.a.b.c), in locally I manually add it with mysql repl, but whether it's OK to do that in spawning a mysql thread?

I then switch to use GreptimeDbStandalone

greptimedb/tests-integration/src/standalone.rs

Lines 42 to 49 in c00c1d9

	pub struct GreptimeDbStandalone {
	pub instance: Arc<Instance>,
	pub mix_options: MixOptions,
	pub guard: TestGuard,
	// Used in rebuild.
	pub kv_backend: KvBackendRef,
	pub procedure_manager: ProcedureManagerRef,
	}

, which can easily run sql but I don't know how to communicate greptime cli export with it. I think I need to craft Export first

greptimedb/src/cmd/src/cli/export.rs

Lines 118 to 125 in c00c1d9

	pub struct Export {
	client: Database,
	catalog: String,
	schema: Option<String>,
	output_dir: String,
	parallelism: usize,
	target: ExportTarget,
	}

then call export_create_table, but I don't make it.

[MichaelScofield]

@dimbtp I think you can refer to how the repl was tested before in "src/cmd/tests/cli.rs".

[tisonkun]

Shared concern.

[MichaelScofield]

@dimbtp I mean you can use the same methods like how to use Command or how to handle the client in src/cmd/tests/cli.rs.

[tisonkun]

I'm OK with this. But may other reviewers would suggest how to add tests further.

[dimbtp]

@killme2008 @MichaelScofield @tisonkun A simple test and PTAL.

[dimbtp]

@killme2008 @MichaelScofield @tisonkun PTAL

[tisonkun]

@dimbtp the bin based test are super dirty. Since we already in the cmd crate, we can write more reliable and clean test cases. (I push a commit to refactor it.)

@MichaelScofield perhaps the REPL test case can leverage the code I push in the last commit ..

[tisonkun]

However, still thank a lot to nudge and drive this effort!