Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create database api change in protobuf #3682

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

CookiePieWw
Copy link
Collaborator

@CookiePieWw CookiePieWw commented Apr 9, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

close #3662

What's changed and what's your intention?

database_name to schema_name corresponding to the change in greptime-proto.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Apr 9, 2024
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.84%. Comparing base (2398918) to head (7a582c9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3682      +/-   ##
==========================================
- Coverage   85.16%   84.84%   -0.32%     
==========================================
  Files         951      951              
  Lines      158924   159005      +81     
==========================================
- Hits       135341   134910     -431     
- Misses      23583    24095     +512     

@WenyXu
Copy link
Member

WenyXu commented Apr 9, 2024

Thanks!🙏

@shuiyisong shuiyisong added this pull request to the merge queue Apr 9, 2024
Merged via the queue into GreptimeTeam:main with commit 34f935d Apr 9, 2024
22 checks passed
@CookiePieWw CookiePieWw deleted the create-database-api branch April 9, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change create database api's protobuf definition
3 participants