Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DeserializedValueWithBytes::from_inner misusing #3676

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Apr 8, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

We shouldn't use the DeserializedValueWithBytes::from_inner for non-test purposes.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Apr 8, 2024
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 78.12500% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 84.84%. Comparing base (3e1a125) to head (3764ec4).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3676      +/-   ##
==========================================
- Coverage   85.19%   84.84%   -0.36%     
==========================================
  Files         949      949              
  Lines      158557   158602      +45     
==========================================
- Hits       135080   134559     -521     
- Misses      23477    24043     +566     

@tisonkun tisonkun changed the title fix: fix DeserializedValueWithBytes::from_inner misusing fix: DeserializedValueWithBytes::from_inner misusing Apr 8, 2024
src/common/meta/src/key.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun added this pull request to the merge queue Apr 9, 2024
Merged via the queue into GreptimeTeam:main with commit b51089f Apr 9, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants