Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add timers to more mito methods #3659

Merged

Conversation

evenyag
Copy link
Contributor

@evenyag evenyag commented Apr 8, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

This PR adds timers to more mito methods

  • edit_region
  • set_readonly_gracefully

It also combines RegionRequest::request_type() and RegionRequest::type_name() into one method.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Apr 8, 2024
@evenyag evenyag marked this pull request as ready for review April 8, 2024 04:23
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 84.84%. Comparing base (7e8e9ab) to head (c11de85).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3659      +/-   ##
==========================================
- Coverage   85.13%   84.84%   -0.30%     
==========================================
  Files         943      943              
  Lines      157092   157220     +128     
==========================================
- Hits       133744   133390     -354     
- Misses      23348    23830     +482     

@MichaelScofield MichaelScofield added this pull request to the merge queue Apr 8, 2024
Merged via the queue into GreptimeTeam:main with commit 89db8c1 Apr 8, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants