Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add checksum for checkpoint data #3651

Merged
merged 6 commits into from
Apr 9, 2024

Conversation

tisonkun
Copy link
Contributor

@tisonkun tisonkun commented Apr 7, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

This closes #2164.

This supersedes #3090.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Apr 7, 2024
Signed-off-by: tison <[email protected]>
Copy link

codecov bot commented Apr 7, 2024

Codecov Report

Attention: Patch coverage is 98.87640% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 84.83%. Comparing base (2398918) to head (55073a0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3651      +/-   ##
==========================================
- Coverage   85.16%   84.83%   -0.33%     
==========================================
  Files         951      951              
  Lines      158924   159005      +81     
==========================================
- Hits       135341   134899     -442     
- Misses      23583    24106     +523     

src/mito2/src/error.rs Outdated Show resolved Hide resolved
src/mito2/src/manifest/storage.rs Outdated Show resolved Hide resolved
src/mito2/src/manifest/storage.rs Outdated Show resolved Hide resolved
src/mito2/src/manifest/storage.rs Show resolved Hide resolved
src/mito2/src/manifest/storage.rs Show resolved Hide resolved
@killme2008
Copy link
Contributor

@evenyag PTAL

@tisonkun
Copy link
Contributor Author

tisonkun commented Apr 9, 2024

@killme2008 all comments resolved.

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@killme2008 killme2008 added this pull request to the merge queue Apr 9, 2024
Merged via the queue into GreptimeTeam:main with commit 2c0c775 Apr 9, 2024
20 checks passed
@tisonkun tisonkun deleted the checkpoint_checksum branch April 9, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement checkpoint checksum
3 participants