feat: add strict mode to validate protocol strings

[irenjj]

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

#3435

What's changed and what's your intention?

provide a strict mode to perform UTF-8 validation

Checklist

• I have written the necessary rustdoc comments.
• I have added the necessary unit tests and integration tests.
• This PR does not require documentation updates.

[v0y4g3r]

Hi @irenjj I notice this draft is rather close to complete, can you add some tests for invalid UTF8 strings in labels and fix the CI workflows so that we can proceed?

[irenjj]

Hi @irenjj I notice this draft is rather close to complete, can you add some tests for invalid UTF8 strings in labels and fix the CI workflows so that we can proceed?

Sure, I'll take care of adding tests for invalid UTF8 strings right away.

[killme2008]

@v0y4g3r @etolbakov PTAL

[etolbakov]

Overall LGTM @irenjj, raised several points, will have another look (and approve) later today.

[tisonkun]

Fail test:

TRY 4 FAIL [ 1.139s] tests-integration::main integration_http_file_test::test_config_api

[v0y4g3r]

@irenjj Thanks, I've quickly walk through the PR and left some commet.

Despite these, you may also need to fix the test_config_api unit test which checks if runtime config retrieval API works as expected:

greptimedb/tests-integration/tests/http.rs

Line 675 in b32e0bb

pub async fn test_config_api(store_type: StorageType) {

Also, the PR adds a config option to greptime binary, so would you mind adding to documentation for this option in greptimedb's doc repo so that it can be reflected in the official doc page. The related doc file is https://github.com/GreptimeTeam/docs/blob/main/docs/v0.7/en/user-guide/operations/configuration.md#protocol-options

[irenjj]

@irenjj Thanks, I've quickly walk through the PR and left some commet.

Despite these, you may also need to fix the test_config_api unit test which checks if runtime config retrieval API works as expected:

greptimedb/tests-integration/tests/http.rs

Line 675 in b32e0bb

pub async fn test_config_api(store_type: StorageType) {

Also, the PR adds a config option to greptime binary, so would you mind adding to documentation for this option in greptimedb's doc repo so that it can be reflected in the official doc page. The related doc file is https://github.com/GreptimeTeam/docs/blob/main/docs/v0.7/en/user-guide/operations/configuration.md#protocol-options

Sure, i'll fix all review issues and add doc.

[codecov]

Codecov Report

Attention: Patch coverage is 62.90323% with 46 lines in your changes are missing coverage. Please review.

Project coverage is 85.22%. Comparing base (db329f6) to head (b24ac6f).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3638      +/-   ##
==========================================
- Coverage   85.57%   85.22%   -0.35%     
==========================================
  Files         962      962              
  Lines      160274   160371      +97     
==========================================
- Hits       137155   136683     -472     
- Misses      23119    23688     +569     

[v0y4g3r]

LGTM

[waynexia]

Others LGTM, thanks @irenjj, also thanks for your review @etolbakov @v0y4g3r