-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cluster information #3631
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3631 +/- ##
==========================================
- Coverage 85.14% 84.80% -0.35%
==========================================
Files 943 946 +3
Lines 157092 157547 +455
==========================================
- Hits 133754 133604 -150
- Misses 23338 23943 +605 |
544cceb
to
9f481e0
Compare
c396c54
to
64f73a4
Compare
23a5933
to
862a091
Compare
862a091
to
d6f61f1
Compare
src/meta-srv/src/handler/collect_datanode_cluster_info_handler.rs
Outdated
Show resolved
Hide resolved
src/meta-srv/src/handler/collect_frontend_cluster_info_handler.rs
Outdated
Show resolved
Hide resolved
src/meta-srv/src/handler/collect_datanode_cluster_info_handler.rs
Outdated
Show resolved
Hide resolved
The comments have all been resolved, please take a look @killme2008 @MichaelScofield |
2db4342
to
40f5dd2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Close #3294 , allow meta client to get some information of all nodes in the cluster, the implementation is divided into the following steps:
CollectDatanodeClusterInfoHandler
andCollectFrontendClusterInfoHandler
, which are used to process heartbeats requests from datanodes and frontends. These handlers extract information and write it into the in-memory KV storage on the metasrv leader node.range
andbatch_get
APIs.ClusterInfo
trait for the cluster client, and implement thelist_nodes
method based on the kv service to return information about all node states.Other: The information for the Metasrv node will not be included in this PR as it is about to exceed 1000 lines.
Checklist