Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(procedure): enable auto split large value #3628

Merged
merged 9 commits into from
Apr 2, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Apr 2, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

  1. Enable auto split large value
  2. Add max_value_size configuration to [procedure] section in metasrv.example.toml, with default value 1535KiB.
  3. Add max_value_size to ProcedureConfig, type of Option<size> the default value is None(no max size limit).

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Apr 2, 2024
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.03%. Comparing base (6c316d2) to head (447b5fe).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3628      +/-   ##
==========================================
- Coverage   85.36%   85.03%   -0.33%     
==========================================
  Files         935      939       +4     
  Lines      156348   156409      +61     
==========================================
- Hits       133463   133000     -463     
- Misses      22885    23409     +524     

src/common/procedure/src/options.rs Outdated Show resolved Hide resolved
src/meta-srv/src/metasrv/builder.rs Outdated Show resolved Hide resolved
config/metasrv.example.toml Outdated Show resolved Hide resolved
config/metasrv.example.toml Show resolved Hide resolved
src/common/meta/src/state_store.rs Outdated Show resolved Hide resolved
@WenyXu
Copy link
Member Author

WenyXu commented Apr 2, 2024

@fengjiachun @evenyag PTAL

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evenyag evenyag added this pull request to the merge queue Apr 2, 2024
Merged via the queue into GreptimeTeam:main with commit a0f243c Apr 2, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants