Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(function): add timestamp epoch integer support for to_timezone #3620

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

etolbakov
Copy link
Collaborator

@etolbakov etolbakov commented Mar 29, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link

This fixed #3477

What's changed and what's your intention?

updated to_timezone logic to support UNIX millisecond timestamp numerical values like 1711508510000

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 29, 2024
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 91.30435% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 85.12%. Comparing base (93da45f) to head (ac1e4f3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3620      +/-   ##
==========================================
- Coverage   85.44%   85.12%   -0.33%     
==========================================
  Files         932      932              
  Lines      155142   155192      +50     
==========================================
- Hits       132567   132102     -465     
- Misses      22575    23090     +515     

@etolbakov etolbakov requested a review from tisonkun March 29, 2024 13:52
@etolbakov
Copy link
Collaborator Author

Hi @tisonkun
Could you please take a look when you have time?

Copy link
Collaborator

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat and correct. Thank you!

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008 killme2008 added this pull request to the merge queue Mar 29, 2024
Merged via the queue into GreptimeTeam:main with commit 18d6768 Mar 29, 2024
18 checks passed
@etolbakov etolbakov deleted the to_timezone-integer-support branch March 29, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support timestamp epoch integer in to_timezone function
3 participants