Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update physical table schema on alter logical tables #3585

Merged

Conversation

fengjiachun
Copy link
Collaborator

@fengjiachun fengjiachun commented Mar 26, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

  • Update the physical table schema when altering logical tables;
  • Invalidate the cache in frontend when schema changed;
  • Let the alter logical table from sql console go into the new alter procedure;
  • Add sqlness test of alter logical tables.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 26, 2024
@fengjiachun fengjiachun force-pushed the feat/phy-schema-on-alter-logical-tables branch from 866edde to 1616175 Compare March 26, 2024 08:01
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 50.45455% with 109 lines in your changes are missing coverage. Please review.

Project coverage is 84.81%. Comparing base (7456515) to head (a700c2c).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3585      +/-   ##
==========================================
- Coverage   85.19%   84.81%   -0.39%     
==========================================
  Files         924      926       +2     
  Lines      153492   153645     +153     
==========================================
- Hits       130773   130318     -455     
- Misses      22719    23327     +608     

Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun
Copy link
Collaborator Author

@evenyag PTAL

Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

src/common/meta/src/ddl/create_logical_tables.rs Outdated Show resolved Hide resolved
@evenyag evenyag enabled auto-merge March 26, 2024 14:17
@evenyag evenyag added this pull request to the merge queue Mar 26, 2024
Merged via the queue into GreptimeTeam:main with commit 58c7858 Mar 26, 2024
19 checks passed
@fengjiachun fengjiachun deleted the feat/phy-schema-on-alter-logical-tables branch March 27, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants