-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement append mode for a region #3558
feat: Implement append mode for a region #3558
Conversation
ad748b4
to
051e8ea
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3558 +/- ##
==========================================
- Coverage 85.15% 84.84% -0.31%
==========================================
Files 929 930 +1
Lines 154003 154236 +233
==========================================
- Hits 131137 130862 -275
- Misses 22866 23374 +508 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How to set this mode? Rest LGTM
I'll expose this to table options in another PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
This PR implements append mode for a mito region.
append_mode
is false and the engine removes duplicate rows.append_mode
is true, the engine keeps all duplicate rows.It adds a
dedup
flag to theMergeReader
. TheMergeReader
will keep rows with duplicate keys but still yield rows in sorted order.Checklist