refactor: handle error for http format #3548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
tisonkun
commented
Mar 20, 2024
4559171
to
0d8f5c1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3548 +/- ##
==========================================
- Coverage 85.36% 84.98% -0.38%
==========================================
Files 910 910
Lines 152030 152022 -8
==========================================
- Hits 129780 129203 -577
- Misses 22250 22819 +569 |
Signed-off-by: tison <[email protected]>
0d8f5c1
to
d8e6597
Compare
shuiyisong
reviewed
Mar 21, 2024
MichaelScofield
pushed a commit
to MichaelScofield/greptimedb
that referenced
this pull request
Mar 22, 2024
* refactor: handle error for http format Signed-off-by: tison <[email protected]> * finish format handling Signed-off-by: tison <[email protected]> * simplify auth error Signed-off-by: tison <[email protected]> * fix Signed-off-by: tison <[email protected]> * clippy format Signed-off-by: tison <[email protected]> * no longer set greptime-db-format on influxdb error Signed-off-by: tison <[email protected]> --------- Signed-off-by: tison <[email protected]>
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Perhaps we can further tidy error handling code by
impl <T: ErrorExt> From<T> for ErrorResponse, but this PR is large enough.Checklist