Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Renames the new memtable to PartitionTreeMemtable #3547

Merged
merged 5 commits into from
Mar 20, 2024

Conversation

evenyag
Copy link
Contributor

@evenyag evenyag commented Mar 20, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

This PR renames the new memtable (MergeTreeMemtable) to PartitionTreeMemtable. All experimental configurations for the new memtable will be changed to use partition_tree.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added breaking-change This pull request contains breaking changes. docs-not-required This change does not impact docs. labels Mar 20, 2024
@evenyag evenyag marked this pull request as ready for review March 20, 2024 04:22
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 91.48936% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 84.98%. Comparing base (6377982) to head (f9d5a20).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3547      +/-   ##
==========================================
- Coverage   85.36%   84.98%   -0.39%     
==========================================
  Files         910      910              
  Lines      152030   152034       +4     
==========================================
- Hits       129780   129202     -578     
- Misses      22250    22832     +582     

Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v0y4g3r v0y4g3r added this pull request to the merge queue Mar 20, 2024
Merged via the queue into GreptimeTeam:main with commit 39b69f1 Mar 20, 2024
35 of 46 checks passed
@v0y4g3r v0y4g3r deleted the refactor/rename-memtable branch March 20, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change This pull request contains breaking changes. docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants