-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: Renames the new memtable to PartitionTreeMemtable #3547
Conversation
45ee8a6
to
f9d5a20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3547 +/- ##
==========================================
- Coverage 85.36% 84.98% -0.39%
==========================================
Files 910 910
Lines 152030 152034 +4
==========================================
- Hits 129780 129202 -578
- Misses 22250 22832 +582 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
This PR renames the new memtable (MergeTreeMemtable) to
PartitionTreeMemtable
. All experimental configurations for the new memtable will be changed to usepartition_tree
.Checklist