-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow cross-schema query in promql #3545
feat: allow cross-schema query in promql #3545
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3545 +/- ##
==========================================
- Coverage 85.40% 85.06% -0.34%
==========================================
Files 931 931
Lines 154826 154941 +115
==========================================
- Hits 132224 131800 -424
- Misses 22602 23141 +539 |
8b8f5b4
to
b4bfc98
Compare
Updated |
@waynexia PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Would prefer to also add some sqlness test
Do we have sqlness for promql? I didn't see them so I added tests in tests-integration. |
Rerfer to https://github.com/GreptimeTeam/greptimedb/tree/main/tests/cases/standalone/common/tql |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
This patch adds special matcher
__schema__
for our promql parser for selecting a schema where the table sits. This allows user to do cross-schema query in promql.The patch also does some refactoring in promql parser.
Checklist