Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: reduce one clone by carefully pass ready boundary #3543

Merged
merged 5 commits into from
Mar 22, 2024
Merged

refactor: reduce one clone by carefully pass ready boundary #3543

merged 5 commits into from
Mar 22, 2024

Conversation

tisonkun
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

This follows up #3542. Hopefully I don't introduce new subtle issues 🥵

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 19, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.99%. Comparing base (8b7a5aa) to head (9dc00c1).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3543      +/-   ##
==========================================
- Coverage   85.37%   84.99%   -0.38%     
==========================================
  Files         910      910              
  Lines      152023   152023              
==========================================
- Hits       129783   129215     -568     
- Misses      22240    22808     +568

evenyag
evenyag approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia enabled auto-merge March 22, 2024 04:42
@waynexia waynexia added this pull request to the merge queue Mar 22, 2024
Merged via the queue into GreptimeTeam:main with commit 3420a01 Mar 22, 2024
19 checks passed
@tisonkun tisonkun mentioned this pull request Apr 9, 2024
Merged
12 tasks
@tisonkun tisonkun deleted the reduce-one-clone branch May 3, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evenyag evenyag evenyag approved these changes

@waynexia waynexia waynexia approved these changes

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tisonkun @evenyag @waynexia