-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: http header with metrics #3536
feat: http header with metrics #3536
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3536 +/- ##
==========================================
- Coverage 85.38% 84.96% -0.43%
==========================================
Files 906 906
Lines 151023 151078 +55
==========================================
- Hits 128952 128361 -591
- Misses 22071 22717 +646 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This seems a |
This is actually a feature 😹 |
Although we miss the chance to correct the commit message, let's change the PR title ... |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
This pr is a follow-up of #3466.
Now that we have
OutputMeta
, we can easily bring metrics from execution level up to the HTTP interface and put them into HTTP header.This pr covers basically every HTTP entry with read or write request, returning a HTTP header indicating the cost of the request.
Checklist