Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove removed-prefixed keys #3535

Merged

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Mar 18, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

This PR removed the removed prefixed keys; these keys weren't in use.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 18, 2024
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.96%. Comparing base (393ea44) to head (921288a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3535      +/-   ##
==========================================
- Coverage   85.38%   84.96%   -0.42%     
==========================================
  Files         906      906              
  Lines      151023   150953      -70     
==========================================
- Hits       128952   128264     -688     
- Misses      22071    22689     +618     

Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

May you cross-refer where we remove they valid usage? Or why we don't need it now.

@WenyXu
Copy link
Member Author

WenyXu commented Mar 18, 2024

Thank you!

May you cross-refer where we remove they valid usage? Or why we don't need it now.

Actually, we don't require data to be restored from these key values.

@MichaelScofield MichaelScofield added this pull request to the merge queue Mar 18, 2024
Merged via the queue into GreptimeTeam:main with commit 343525d Mar 18, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants