Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: introduce the DropTableExecutor #3534

Merged
merged 4 commits into from
Mar 19, 2024
Merged

refactor: introduce the DropTableExecutor #3534

merged 4 commits into from
Mar 19, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Mar 18, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Introduce the DropTableExecutor. The prelude of #825

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 18, 2024
fengjiachun
fengjiachun approved these changes Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I noticed that you introduced an executor to refactor the DropTable DDL, and I'm curious if you are going do the same thing for other DDLs as well?

src/common/meta/src/ddl/drop_table.rs Show resolved Hide resolved
@WenyXu
Copy link
Member Author

WenyXu commented Mar 19, 2024

LGTM, I noticed that you introduced an executor to refactor the DropTable DDL, and I'm curious if you are going do the same thing for other DDLs as well?

Yes

@fengjiachun fengjiachun added this pull request to the merge queue Mar 19, 2024
Merged via the queue into GreptimeTeam:main with commit fa0f355 Mar 19, 2024
17 checks passed
@WenyXu WenyXu mentioned this pull request Mar 19, 2024
Closed
9 tasks
@tisonkun tisonkun mentioned this pull request Apr 9, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelScofield MichaelScofield MichaelScofield approved these changes

@fengjiachun fengjiachun fengjiachun approved these changes

@waynexia waynexia Awaiting requested review from waynexia

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@WenyXu @MichaelScofield @fengjiachun