feat: support per table memtable options #3524
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
This PR supports configuring memtable options for each table. It replaces the global memtable builder in the worker with a builder factory
MemtableBuilderProvider
.By default, all regions use the same
default_memtable_builder
. Ifmemtable.type
is specified in the region options, the provider will create a new memtable for the region. The memtable config in theMitoConfig
only applies to the default memtable.This PR changes the default global memtable to the old
time_series
memtable. It enables the new memtable in the metric engine by setting the memtable type explicitly.It also fixes an issue that the region uses the default value instead of returning an error if
compaction.twcs.max_active_window_files
isn't a valid integer.Checklist