-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mito): Checks whether a region should flush periodically #3459
Merged
fengjiachun
merged 8 commits into
GreptimeTeam:main
from
evenyag:feat/worker-auto-flush
Mar 15, 2024
Merged
feat(mito): Checks whether a region should flush periodically #3459
fengjiachun
merged 8 commits into
GreptimeTeam:main
from
evenyag:feat/worker-auto-flush
Mar 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evenyag
force-pushed
the
feat/worker-auto-flush
branch
2 times, most recently
from
March 12, 2024 03:11
e65fa6a
to
4f77f89
Compare
Mock a time provider to test auto flush
evenyag
force-pushed
the
feat/worker-auto-flush
branch
from
March 14, 2024 03:43
4f77f89
to
812855b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3459 +/- ##
==========================================
- Coverage 85.30% 85.00% -0.31%
==========================================
Files 904 906 +2
Lines 150170 150925 +755
==========================================
+ Hits 128106 128288 +182
- Misses 22064 22637 +573 |
MichaelScofield
approved these changes
Mar 14, 2024
fengjiachun
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
This PR checks whether a region should flush periodically and flush it if its last flush time is earlier than
auto_flush_interval
. The previous implementation only triggers the check on flush, which implies the write buffer is full. It might cause the database to hold a large amount of data for a long time if users stop ingesting data.This PR
TimeProvider
to get the current timestamp and checks elapsed time, this also simplifies test implementationEach worker will start with a random check delay between
[0, MAX_INITIAL_CHECK_DELAY_SECS)
to avoid them flush together.Checklist