Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement log related macros #29

Merged
merged 1 commit into from
May 17, 2022
Merged

feat: implement log related macros #29

merged 1 commit into from
May 17, 2022

Conversation

evenyag
Copy link
Contributor

@evenyag evenyag commented May 17, 2022

Implement log, trace, debug, info, warn, error macros, customize error log output format

Now printing an error log should use the new error! macro

error!(e; "hello {}", "world");

@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #29 (e1a8e44) into develop (93cbdbe) will increase coverage by 1.08%.
The diff coverage is 92.95%.

@@             Coverage Diff             @@
##           develop      #29      +/-   ##
===========================================
+ Coverage    37.92%   39.00%   +1.08%     
===========================================
  Files           69       70       +1     
  Lines         4285     4358      +73     
===========================================
+ Hits          1625     1700      +75     
+ Misses        2660     2658       -2     
Flag Coverage Δ
rust 39.00% <92.95%> (+1.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/error/src/ext.rs 96.47% <ø> (ø)
src/common/error/src/format.rs 74.46% <ø> (ø)
src/common/telemetry/src/lib.rs 100.00% <ø> (ø)
src/common/telemetry/src/logging.rs 84.37% <ø> (ø)
src/common/telemetry/src/metric.rs 82.92% <0.00%> (ø)
src/common/error/src/mock.rs 78.26% <92.30%> (+21.11%) ⬆️
src/common/telemetry/src/macros.rs 95.16% <94.73%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93cbdbe...e1a8e44. Read the comment docs.

@killme2008
Copy link
Contributor

LGTM

@v0y4g3r v0y4g3r merged commit 3d374cc into develop May 17, 2022
@evenyag evenyag deleted the feat-logging-macros branch May 17, 2022 08:23
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants