feat: impl object-store based on opendal #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killme2008
force-pushed
the
feature/object-storage
branch
from
4e1e9f0
to
dc9f34a
Compare
Codecov Report
@@ Coverage Diff @@
## develop #27 +/- ##
===========================================
+ Coverage 37.92% 38.86% +0.93%
===========================================
Files 69 71 +2
Lines 4285 4354 +69
===========================================
+ Hits 1625 1692 +67
- Misses 2660 2662 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
evenyag
approved these changes
May 17, 2022
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat: impl object-store based on opendal * feat: adds s3 test * feat: export Layer * feat: pass s3 access key/secret by env vars * fix: logging when s3 test is running
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impl object-store service based on opendal, it's just a simple wrapper right now.
TODO:
append?