Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add serialization support to existing data types #24

Merged
merged 2 commits into from
May 11, 2022

Conversation

v0y4g3r
Copy link
Contributor

@v0y4g3r v0y4g3r commented May 10, 2022

Implements serialize-to-json feature for existing data types, including PrimitiveVector and BinaryVector

@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #24 (fb38049) into develop (5c72c5a) will increase coverage by 0.31%.
The diff coverage is 71.73%.

@@             Coverage Diff             @@
##           develop      #24      +/-   ##
===========================================
+ Coverage    36.59%   36.91%   +0.31%     
===========================================
  Files           64       65       +1     
  Lines         4091     4145      +54     
===========================================
+ Hits          1497     1530      +33     
- Misses        2594     2615      +21     
Flag Coverage Δ
rust 36.91% <71.73%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/recordbatch/src/recordbatch.rs 93.33% <ø> (ø)
src/datatypes/src/lib.rs 100.00% <ø> (ø)
src/datatypes/src/vectors/primitive.rs 72.00% <0.00%> (-28.00%) ⬇️
src/datatypes/src/error.rs 77.27% <77.27%> (ø)
src/datatypes/src/vectors/binary.rs 60.00% <94.11%> (+17.57%) ⬆️
src/sql/src/parser.rs 20.17% <0.00%> (-0.29%) ⬇️
src/sql/src/error.rs 71.11% <0.00%> (+3.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c72c5a...fb38049. Read the comment docs.

src/datatypes/src/errors.rs Outdated Show resolved Hide resolved
src/datatypes/src/errors.rs Outdated Show resolved Hide resolved
src/datatypes/src/lib.rs Outdated Show resolved Hide resolved
src/datatypes/src/serialize.rs Outdated Show resolved Hide resolved
src/datatypes/src/vectors/binary.rs Outdated Show resolved Hide resolved
src/datatypes/src/vectors/primitive.rs Outdated Show resolved Hide resolved
src/datatypes/src/vectors/binary.rs Outdated Show resolved Hide resolved
src/datatypes/src/vectors/binary.rs Outdated Show resolved Hide resolved
src/datatypes/src/vectors/primitive.rs Outdated Show resolved Hide resolved
@v0y4g3r v0y4g3r force-pushed the feat/type_serde branch 3 times, most recently from 3903833 to 6fcd131 Compare May 11, 2022 03:46
src/datatypes/src/error.rs Outdated Show resolved Hide resolved
src/datatypes/src/lib.rs Outdated Show resolved Hide resolved
@evenyag evenyag merged commit 641f4b3 into develop May 11, 2022
@evenyag evenyag deleted the feat/type_serde branch May 11, 2022 09:17
@v0y4g3r v0y4g3r restored the feat/type_serde branch May 11, 2022 09:17
@v0y4g3r v0y4g3r deleted the feat/type_serde branch May 11, 2022 09:17
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* feat: add serialization support to existing data types

* fix: refactor errors mod to error. fix other review comments
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants