feat: support to copy from orc format #1814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2c48df2
to
e7b9521
Compare
e7b9521
to
47484d6
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1814 +/- ##
===========================================
- Coverage 86.38% 86.13% -0.26%
===========================================
Files 584 585 +1
Lines 95458 95502 +44
===========================================
- Hits 82462 82259 -203
- Misses 12996 13243 +247 |
MichaelScofield
approved these changes
Jun 25, 2023
fengjiachun
reviewed
Jun 25, 2023
|
@fengjiachun PTAL |
fengjiachun
approved these changes
Jun 25, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat: support to copy from orc format * test: add copy from orc test * chore: add license header * refactor: remove unimplemented macro * chore: apply suggestions from CR * chore: bump orc-rust to 0.2.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Notes: currently, it doesn't support the Run Length Encoding defined in orc spec v0, the writer should use Run Length Encoding V2 instead.
See also orc-rust
TL;DR
I was planning to support the import of orc format data based on orc-format crate, but I found a lot of bugs in the process of supplementing unit testing, and finally, I rewrote the entire rlev2 algorithm based on the orc and supported of timestamp, date types decoding, added an async stream reader.
Checklist
Refer to a related PR or issue link (optional)