-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement SELECT query parser. #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt(s) in unit tests; refactor crate layout; feat: wrap sqlparser error;
# Conflicts: # Cargo.lock # src/sql/Cargo.toml # src/sql/src/errors.rs # src/sql/src/lib.rs # src/sql/src/parser.rs # src/sql/src/statements/mod.rs # src/sql/src/statements/statement.rs
evenyag
reviewed
Apr 26, 2022
killme2008
reviewed
Apr 27, 2022
killme2008
reviewed
Apr 27, 2022
killme2008
reviewed
Apr 27, 2022
killme2008
reviewed
Apr 27, 2022
evenyag
approved these changes
Apr 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
waynexia
added a commit
to waynexia/greptimedb
that referenced
this pull request
Mar 14, 2023
* feat: implement table flush (GreptimeTeam#1121) * feat: add flush method for trait * feat: implement flush via grpc * chore: move table_dir/region_name/region_id to table crate * chore: Update src/mito/src/table.rs --------- Co-authored-by: Yingwen <[email protected]> * fix: use correct env var (GreptimeTeam#1166) * fix: use correct env var * fix: move COPY up so rustup know it's nightly * fix: add `pyo3_backend` in GHA yml * chore: name for `TODO` * temp: not set `pyo3_backend` before find DSO * fix: release linux with pyo3_backend * fix: failed to run subquery wrapped in two parentheses (GreptimeTeam#1157) * refactor: add the separate GitHub Action job to push the image to the UCloud registry (GreptimeTeam#1170) * refactor: make the cmd hold the application instance (GreptimeTeam#1159) * fix: export 'PYO3_CROSS_LIB_DIR' when cargo build for aarch64-linux and refactor matrix opts (GreptimeTeam#1171) --------- Co-authored-by: Weny Xu <[email protected]> Co-authored-by: Yingwen <[email protected]> Co-authored-by: discord9 <[email protected]> Co-authored-by: LFC <[email protected]> Co-authored-by: zyy17 <[email protected]>
paomian
referenced
this pull request
in paomian/greptimedb
Oct 19, 2023
* feat: Add SQL parser definition and SHOW DATABASE implementation * chores: Eliminate clippy warnings and errors. * chores: remove Gt prefix in some structs; rename some mod; remove print(s) in unit tests; refactor crate layout; feat: wrap sqlparser error; * chores: reorder cargo dependency * chores: fix code style * chores: add #[cfg(test)] to unit tests * style: fix test mod style * feat: implement select query parser * chores: remove unused dependency * feat: implement TryInto<sqlparser::ast::Statement> for Statement * chore: fix style issues * refactor: wrap sqlparser Query inside Query statement variant to reduce complexity * refactor: replace TryInto to TryFrom * refactor: use [Rust 2018 mod convention](https://doc.rust-lang.org/edition-guide/rust-2018/path-changes.html#no-more-modrs)
v0y4g3r
pushed a commit
to v0y4g3r/greptimedb
that referenced
this pull request
Feb 7, 2024
* feat: write to index and data * feat: freeze memtable * feat: write pk to cache * feat: impl fork for the merge tree memtable * feat: impl is_empty * feat: freeze shard * feat: remove cache * feat: shard reader * chore: remove todo * fix: key bytes stats * feat: add bytes to tracker in forked memtable * style: fix clippy * chore: update comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
SELECT
query statement parser.SELECT
statements will be parsed toStatement::Query
variant.WITH
/HAVING
/ORDER BY
keywords currently no supported.