chore: revert changes for request

src/mito2/src/compaction/task.rs

@@ -148,7 +148,7 @@ impl CompactionTask for CompactionTaskImpl {
  let notify = match self.handle_compaction().await {
  Ok(edit) => BackgroundNotify::CompactionFinished(CompactionFinished {
  region_id: self.compaction_region.region_id,
- senders: Some(std::mem::take(&mut self.waiters)),
+ senders: std::mem::take(&mut self.waiters),
  start_time: self.start_time,
  edit,
  }),

src/mito2/src/request.rs

@@ -693,7 +693,7 @@ pub(crate) struct CompactionFinished {
  /// Region id.
  pub(crate) region_id: RegionId,
  /// Compaction result senders.
- pub(crate) senders: Option<Vec<OutputTx>>,
+ pub(crate) senders: Vec<OutputTx>,
  /// Start time of compaction task.
  pub(crate) start_time: Instant,
  /// Region edit to apply.
@@ -705,10 +705,8 @@ impl CompactionFinished {
  // only update compaction time on success
  COMPACTION_ELAPSED_TOTAL.observe(self.start_time.elapsed().as_secs_f64());
 
- if let Some(senders) = self.senders {
- for sender in senders {
- sender.send(Ok(0));
- }
+ for sender in self.senders {
+ sender.send(Ok(0));
  }
 
  info!("Successfully compacted region: {}", self.region_id);
@@ -719,12 +717,10 @@ impl OnFailure for CompactionFinished {
  /// Compaction succeeded but failed to update manifest or region's already been dropped.
  fn on_failure(&mut self, err: Error) {
  let err = Arc::new(err);
- if let Some(senders) = &mut self.senders {
- for sender in senders.drain(..) {
- sender.send(Err(err.clone()).context(CompactRegionSnafu {
- region_id: self.region_id,
- }));
- }
+ for sender in self.senders.drain(..) {
+ sender.send(Err(err.clone()).context(CompactRegionSnafu {
+ region_id: self.region_id,
+ }));
  }
  }
 }

src/mito2/src/schedule/remote_job_scheduler.rs

@@ -108,7 +108,7 @@ impl Notifier for DefaultNotifier {
  } else if let Some(region_edit) = result.region_edit {
  BackgroundNotify::CompactionFinished(CompactionFinished {
  region_id: result.region_id,
- senders: None,
+ senders: vec![],
  start_time: result.start_time,
  edit: region_edit,
  })