refactor: cleanup usage of double equals (denoland#3566)

Co-authored-by: Yoshiya Hinosawa <[email protected]>

_tools/release/02_create_pr.ts

@@ -45,7 +45,7 @@ function getPrBody() {
  "```\n";
 
  const actor = Deno.env.get("GH_WORKFLOW_ACTOR");
- if (actor != null) {
+ if (actor !== undefined) {
  text += `\ncc @${actor}`;
  }
 

_tools/release/repo.ts

@@ -17,7 +17,7 @@ export class VersionFile {
 
  get version() {
  const version = VersionFile.#versionRe.exec(this.#fileText);
- if (version == null) {
+ if (version === null) {
  throw new Error(`Could not find version in text: ${this.#fileText}`);
  } else {
  return semver.parse(version[1])!;

archive/tar.ts

@@ -188,7 +188,7 @@ export class Tar {
  if (i < 0 || fileName.length > 100) {
  throw new Error(errMsg);
  } else {
- assert(fileNamePrefix != null);
+ assert(fileNamePrefix !== undefined);
  if (fileNamePrefix.length > 155) {
  throw new Error(errMsg);
  }
@@ -226,7 +226,7 @@ export class Tar {
  }
 
  const fileSize = info?.size ?? opts.contentSize;
- assert(fileSize != null, "fileSize must be set");
+ assert(fileSize !== undefined, "fileSize must be set");
 
  const type = opts.type
  ? FileTypes[opts.type as keyof typeof FileTypes]
@@ -274,13 +274,13 @@ export class Tar {
  const headerArr = formatHeader(tarData);
  readers.push(new Buffer(headerArr));
  if (!reader) {
- assert(filePath != null);
+ assert(filePath !== undefined);
  reader = new FileReader(filePath);
  }
  readers.push(reader);
 
  // to the nearest multiple of recordSize
- assert(tarData.fileSize != null, "fileSize must be set");
+ assert(tarData.fileSize !== undefined, "fileSize must be set");
  readers.push(
  new Buffer(
  clean(

assert/assert_instance_of.ts

@@ -32,10 +32,10 @@ export function assertInstanceOf<T extends AnyConstructor>(
  actualTypeStr = typeof actual;
  }
 
- if (expectedTypeStr == actualTypeStr) {
+ if (expectedTypeStr === actualTypeStr) {
  msg =
  `Expected object to be an instance of "${expectedTypeStr}"${msgSuffix}`;
- } else if (actualTypeStr == "function") {
+ } else if (actualTypeStr === "function") {
  msg =
  `Expected object to be an instance of "${expectedTypeStr}" but was not an instanced object${msgSuffix}`;
  } else {

async/pool.ts

@@ -49,7 +49,7 @@ export function pooledMap<T, R>(
  } catch (e) {
  if (
  e instanceof AggregateError &&
- e.message == ERROR_WHILE_MAPPING_MESSAGE
+ e.message === ERROR_WHILE_MAPPING_MESSAGE
  ) {
  controller.error(e as unknown);
  }
@@ -83,7 +83,7 @@ export function pooledMap<T, R>(
  } catch {
  const errors = [];
  for (const result of await Promise.allSettled(executing)) {
- if (result.status == "rejected") {
+ if (result.status === "rejected") {
  errors.push(result.reason);
  }
  }

collections/drop_last_while.ts

@@ -12,7 +12,7 @@
  *
  * const numbers = [22, 30, 44];
  *
- * const notFortyFour = dropLastWhile(numbers, (i) => i != 44);
+ * const notFortyFour = dropLastWhile(numbers, (i) => i !== 44);
  *
  * assertEquals(
  * notFortyFour,

collections/max_with.ts

@@ -7,7 +7,7 @@
  *
  * The comparator is expected to work exactly like one passed to `Array.sort`,
  * which means that `comparator(a, b)` should return a negative number if `a < b`,
- * a positive number if `a > b` and `0` if `a == b`.
+ * a positive number if `a > b` and `0` if `a === b`.
  *
  * @example
  * ```ts

collections/partition.ts

@@ -12,7 +12,7 @@
  * import { assertEquals } from "https://deno.land/std@$STD_VERSION/assert/assert_equals.ts";
  *
  * const numbers = [5, 6, 7, 8, 9];
- * const [even, odd] = partition(numbers, (it) => it % 2 == 0);
+ * const [even, odd] = partition(numbers, (it) => it % 2 === 0);
  *
  * assertEquals(even, [6, 8]);
  * assertEquals(odd, [5, 7, 9]);

collections/take_while_test.ts

@@ -51,7 +51,7 @@ Deno.test("[collections/takeWhile] Returns empty array when the first element do
 Deno.test("[collections/takeWhile] Returns the same array when all elements match the predicate", () => {
  const arr = [1, 2, 3, 4];
 
- const actual = takeWhile(arr, (i) => i != 400);
+ const actual = takeWhile(arr, (i) => i !== 400);
 
  assertEquals(actual, [1, 2, 3, 4]);
 });

console/_tools/generate_data.ts

@@ -246,7 +246,7 @@ class Table {
 
  this.entries = this.entries.map((i) => {
  const width = this.indexed[i].width();
- if (width == null) throw new TypeError("width cannot be null");
+ if (width === null) throw new TypeError("width cannot be null");
  return width;
  });
 

csv/_io.ts

@@ -38,7 +38,7 @@ export interface ReadOptions {
  * Enabling checking number of expected fields for each row.
  *
  * If positive, each record is required to have the given number of fields.
- * If == 0, it will be set to the number of fields in the first row, so that
+ * If === 0, it will be set to the number of fields in the first row, so that
  * future rows must have the same field count.
  * If negative, no check is made and records may have a variable number of
  * fields.
@@ -70,7 +70,7 @@ export async function parseRecord(
  return [];
  }
 
- assert(opt.separator != null);
+ assert(opt.separator !== undefined);
 
  let fullLine = line;
  let quoteError: ParseError | null = null;

csv/parse.ts

@@ -104,8 +104,6 @@ class Parser {
  return [];
  }
 
- assert(this.#options.separator != null);
-
  let fullLine = line;
  let quoteError: ParseError | null = null;
  const quote = '"';
@@ -342,7 +340,7 @@ export function parse<const T extends ParseOptions>(
 
  if (opt.skipFirstRow) {
  const head = r.shift();
- assert(head != null);
+ assert(head !== undefined);
  headers = head;
  }
 

datetime/day_of_year.ts

@@ -22,8 +22,7 @@ export function dayOfYear(date: Date): number {
  const yearStart = new Date(date);
 
  yearStart.setFullYear(date.getFullYear(), 0, 0);
- const diff = date.getTime() -
- yearStart.getTime();
+ const diff = date.getTime() - yearStart.getTime();
 
  return Math.floor(diff / DAY);
 }
@@ -47,8 +46,7 @@ export function dayOfYearUtc(date: Date): number {
  const yearStart = new Date(date);
 
  yearStart.setUTCFullYear(date.getUTCFullYear(), 0, 0);
- const diff = date.getTime() -
- yearStart.getTime();
+ const diff = date.getTime() - yearStart.getTime();
 
  return Math.floor(diff / DAY);
 }

dotenv/mod.ts

@@ -254,7 +254,7 @@ export function parse(
  let match;
  const keysForExpandCheck = [];
 
- while ((match = RE_KeyValue.exec(rawDotenv)) != null) {
+ while ((match = RE_KeyValue.exec(rawDotenv)) !== null) {
  const { key, interpolated, notInterpolated, unquoted } = match
  ?.groups as LineParseResult;
 

encoding/hex.ts

@@ -73,7 +73,7 @@ export function decode(src: Uint8Array): Uint8Array {
  dst[i] = (a << 4) | b;
  }
 
- if (src.length % 2 == 1) {
+ if (src.length % 2 === 1) {
  // Check for invalid char before reporting bad length,
  // since the invalid char (if present) is an earlier problem.
  fromHexChar(src[dst.length * 2]);

flags/mod.ts

@@ -372,7 +372,7 @@ function get<TValue>(
 
 function getForce<TValue>(obj: Record<string, TValue>, key: string): TValue {
  const v = get(obj, key);
- assert(v != null);
+ assert(v !== undefined);
  return v;
 }
 
@@ -638,7 +638,7 @@ export function parse<
 
  if (/^--.+=/.test(arg)) {
  const m = arg.match(/^--([^=]+)=(.*)$/s);
- assert(m != null);
+ assert(m !== null);
  const [, key, value] = m;
 
  if (flags.bools[key]) {
@@ -651,11 +651,11 @@ export function parse<
  /^--no-.+/.test(arg) && get(flags.negatable, arg.replace(/^--no-/, ""))
  ) {
  const m = arg.match(/^--no-(.+)/);
- assert(m != null);
+ assert(m !== null);
  setArg(m[1], false, arg, false);
  } else if (/^--.+/.test(arg)) {
  const m = arg.match(/^--(.+)/);
- assert(m != null);
+ assert(m !== null);
  const [, key] = m;
  const next = args[i + 1];
  if (

fmt/printf.ts

@@ -371,7 +371,7 @@ class Printf {
  this.state = State.PERCENT;
  return;
  }
- flags.width = flags.width == -1 ? 0 : flags.width;
+ flags.width = flags.width === -1 ? 0 : flags.width;
  flags.width *= 10;
  flags.width += val;
  }
@@ -710,7 +710,7 @@ class Printf {
  esign = r < 0 ? "-" : "+";
  }
  }
- e = e.length == 1 ? "0" + e : e;
+ e = e.length === 1 ? "0" + e : e;
  const val = `${mantissa}.${fractional}${upcase ? "E" : "e"}${esign}${e}`;
  return this.padNum(val, n < 0);
  }

fs/copy.ts

@@ -228,7 +228,6 @@ function copyDirSync(
  dest = toPathString(dest);
 
  for (const entry of Deno.readDirSync(src)) {
- assert(entry.name != null, "file.name must be set");
  const srcPath = join(src, entry.name);
  const destPath = join(dest, basename(srcPath as string));
  if (entry.isSymlink) {

fs/ensure_symlink.ts

@@ -6,8 +6,8 @@ import { getFileInfoType, toPathString } from "./_util.ts";
 import { isWindows } from "../_util/os.ts";
 
 function resolveSymlinkTarget(target: string | URL, linkName: string | URL) {
- if (typeof target != "string") return target; // URL is always absolute path
- if (typeof linkName == "string") {
+ if (typeof target !== "string") return target; // URL is always absolute path
+ if (typeof linkName === "string") {
  return resolve(dirname(linkName), target);
  } else {
  return new URL(target, linkName);

fs/exists.ts

@@ -82,15 +82,15 @@ export async function exists(
  return false;
  }
  if (options.isReadable) {
- if (stat.mode == null) {
+ if (stat.mode === null) {
  return true; // Exclusive on Non-POSIX systems
  }
- if (Deno.uid() == stat.uid) {
- return (stat.mode & 0o400) == 0o400; // User is owner and can read?
- } else if (Deno.gid() == stat.gid) {
- return (stat.mode & 0o040) == 0o040; // User group is owner and can read?
+ if (Deno.uid() === stat.uid) {
+ return (stat.mode & 0o400) === 0o400; // User is owner and can read?
+ } else if (Deno.gid() === stat.gid) {
+ return (stat.mode & 0o040) === 0o040; // User group is owner and can read?
  }
- return (stat.mode & 0o004) == 0o004; // Others can read?
+ return (stat.mode & 0o004) === 0o004; // Others can read?
  }
  }
  return true;
@@ -173,15 +173,15 @@ export function existsSync(
  return false;
  }
  if (options.isReadable) {
- if (stat.mode == null) {
+ if (stat.mode === null) {
  return true; // Exclusive on Non-POSIX systems
  }
- if (Deno.uid() == stat.uid) {
- return (stat.mode & 0o400) == 0o400; // User is owner and can read?
- } else if (Deno.gid() == stat.gid) {
- return (stat.mode & 0o040) == 0o040; // User group is owner and can read?
+ if (Deno.uid() === stat.uid) {
+ return (stat.mode & 0o400) === 0o400; // User is owner and can read?
+ } else if (Deno.gid() === stat.gid) {
+ return (stat.mode & 0o040) === 0o040; // User group is owner and can read?
  }
- return (stat.mode & 0o004) == 0o004; // Others can read?
+ return (stat.mode & 0o004) === 0o004; // Others can read?
  }
  }
  return true;

fs/expand_glob.ts

@@ -97,11 +97,11 @@ export async function* expandGlob(
  } = split(toPathString(glob));
 
  let fixedRoot = isGlobAbsolute
- ? winRoot != undefined ? winRoot : "/"
+ ? winRoot !== undefined ? winRoot : "/"
  : absRoot;
  while (segments.length > 0 && !isGlob(segments[0])) {
  const seg = segments.shift();
- assert(seg != null);
+ assert(seg !== undefined);
  fixedRoot = joinGlobs([fixedRoot, seg], globOptions);
  }
 
@@ -118,7 +118,7 @@ export async function* expandGlob(
  ): AsyncIterableIterator<WalkEntry> {
  if (!walkInfo.isDirectory) {
  return;
- } else if (globSegment == "..") {
+ } else if (globSegment === "..") {
  const parentPath = joinGlobs([walkInfo.path, ".."], globOptions);
  try {
  if (shouldInclude(parentPath)) {
@@ -128,7 +128,7 @@ export async function* expandGlob(
  throwUnlessNotFound(error);
  }
  return;
- } else if (globSegment == "**") {
+ } else if (globSegment === "**") {
  return yield* walk(walkInfo.path, {
  skip: excludePatterns,
  maxDepth: globstar ? Infinity : 1,
@@ -144,7 +144,7 @@ export async function* expandGlob(
  })
  ) {
  if (
- walkEntry.path != walkInfo.path &&
+ walkEntry.path !== walkInfo.path &&
  walkEntry.name.match(globPattern)
  ) {
  yield walkEntry;
@@ -219,11 +219,11 @@ export function* expandGlobSync(
  } = split(toPathString(glob));
 
  let fixedRoot = isGlobAbsolute
- ? winRoot != undefined ? winRoot : "/"
+ ? winRoot !== undefined ? winRoot : "/"
  : absRoot;
  while (segments.length > 0 && !isGlob(segments[0])) {
  const seg = segments.shift();
- assert(seg != null);
+ assert(seg !== undefined);
  fixedRoot = joinGlobs([fixedRoot, seg], globOptions);
  }
 
@@ -240,7 +240,7 @@ export function* expandGlobSync(
  ): IterableIterator<WalkEntry> {
  if (!walkInfo.isDirectory) {
  return;
- } else if (globSegment == "..") {
+ } else if (globSegment === "..") {
  const parentPath = joinGlobs([walkInfo.path, ".."], globOptions);
  try {
  if (shouldInclude(parentPath)) {
@@ -250,7 +250,7 @@ export function* expandGlobSync(
  throwUnlessNotFound(error);
  }
  return;
- } else if (globSegment == "**") {
+ } else if (globSegment === "**") {
  return yield* walkSync(walkInfo.path, {
  skip: excludePatterns,
  maxDepth: globstar ? Infinity : 1,
@@ -266,7 +266,7 @@ export function* expandGlobSync(
  })
  ) {
  if (
- walkEntry.path != walkInfo.path &&
+ walkEntry.path !== walkInfo.path &&
  walkEntry.name.match(globPattern)
  ) {
  yield walkEntry;