Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'select all points' method to ShapeState struct #1386

Merged
merged 7 commits into from
Sep 5, 2023

Conversation

gautamprikshit1
Copy link
Contributor

Closes #1318

@Keavon Keavon changed the title Added select all points method to ShapeState struct Add 'select all points' method to ShapeState struct Aug 14, 2023
@Keavon Keavon force-pushed the master branch 29 times, most recently from e4251b2 to a871ea6 Compare August 16, 2023 19:58
@Keavon Keavon force-pushed the master branch 12 times, most recently from a0bf5c4 to 5944186 Compare August 30, 2023 02:37
@gautamprikshit1 gautamprikshit1 marked this pull request as ready for review September 4, 2023 01:51
@Keavon
Copy link
Member

Keavon commented Sep 4, 2023

!build

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

📦 Build Complete for 0df924a
https://74f23fa8.graphite.pages.dev

@Keavon
Copy link
Member

Keavon commented Sep 4, 2023

This looks pretty good from my QA testing. However upon playing with it, realized it would probably be more useful to people if it selects all the anchors but not the handles. And if existing handles are already selected, I think(?) we want to just overwrite that by deselecting all the handles and selecting all the anchors. Would you mind making those changes, please?

@Keavon
Copy link
Member

Keavon commented Sep 4, 2023

!build

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

📦 Build Complete for 1786934
https://171fc92c.graphite.pages.dev

@Keavon
Copy link
Member

Keavon commented Sep 4, 2023

There is one other bug I'm noticing which you didn't cause, but it's a bug that interacts with the feature you're adding. I was wondering if you could take on the extra challenge to try and fix it too. Currently, if you have multiple points selected, clicking on one of those selected points (which deselects all but then re-selects that one clicked point) doesn't update the overlays so it visually appears like that click didn't do anything (however, if you hit G to move the selected points around, you'll see how it's indeed the one point that's selected).

So the fix is to find where to update the overlays for this specific code path.

@Keavon
Copy link
Member

Keavon commented Sep 5, 2023

!build

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

📦 Build Complete for 96054c3
https://6fe77c0d.graphite.pages.dev

Copy link
Member

@Keavon Keavon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🎉

@Keavon Keavon merged commit ad9ccaa into GraphiteEditor:master Sep 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select all points in path tool
3 participants