Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add .envrc to gitignore #841

Closed
wants to merge 1 commit into from

Conversation

jhult
Copy link
Collaborator

@jhult jhult commented Jun 13, 2024

No description provided.

@robinbb
Copy link
Member

robinbb commented Jun 13, 2024

But the .envrc is not to be ignored? We check it in. We change it as needed. Maybe you're thinking of the .env file?

@jhult
Copy link
Collaborator Author

jhult commented Jun 13, 2024

But the .envrc is not to be ignored? We check it in. We change it as needed. Maybe you're thinking of the .env file?

@robinbb,

https://www.toptal.com/developers/gitignore/api/direnv recommends to ignore .envrc. More details here and here.

@robinbb
Copy link
Member

robinbb commented Jun 13, 2024

That first document has a link to https://github.com/direnv/direnv/wiki/.envrc-Boilerplate which says ".gitignore .env, but commit .env{rc,.sample,*} files; see Git Tips". It does not say to ignore .envrc. Also, even if it did, I would argue with it. The .envrc is intended to convey how to configure the developer environment so that all devs are working from same environment.

@jhult
Copy link
Collaborator Author

jhult commented Jun 14, 2024

Since I don't have strong feelings on this, and since the https://github.com/direnv/direnv wiki has conflicting info, I'm going to close this.

@jhult jhult closed this Jun 14, 2024
@jhult jhult deleted the chore/gitignore-envrc branch June 14, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants