Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the app's desktop file name #50

Conversation

michaelweghorn
Copy link
Contributor

Set the desktop file name for the application using QGuiApplication::setDesktopFileName. This is used by window managers/Wayland compositors like KWin to display the proper window icon on Wayland rather than a generic Wayland icon.

On Linux, the desktop file is searched in $XDG_DATA_DIRS (see the desktop file spec, so the desktop file installed to /usr/share/applications/com.governikus.ausweisapp2.desktop is found this way.

Screenshot with v2.1.0 (i.e. without this change in place):

screenshot_ausweisapp_wayland_icon

Screenshot with this change in place:

screenshot_ausweisapp_correct_icon

@CLAassistant
Copy link

CLAassistant commented Mar 24, 2024

CLA assistant check
All committers have signed the CLA.

Set the desktop file name for the application using
QGuiApplication::setDesktopFileName [1]. This is used by
window managers/Wayland compositors like KWin to display
the proper window icon on Wayland rather than a generic
Wayland icon.

On Linux, the desktop file is searched in $XDG_DATA_DIRS (see
the desktop file spec, [2]), so the desktop file installed to
`/usr/share/applications/com.governikus.ausweisapp2.desktop`
is found this way.

[1] https://doc.qt.io/qt-6/qguiapplication.html#desktopFileName-prop
[2] https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html
@misery misery force-pushed the michaelweghorn/set_desktop_file_name branch from 32fbd93 to 383ef9a Compare March 25, 2024 11:27
@misery misery self-assigned this Mar 25, 2024
@misery misery merged commit 1cabf9b into Governikus:community Mar 25, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants