Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing UI with Qt 6.6 #49

Closed
wants to merge 1 commit into from
Closed

Conversation

tvogel
Copy link

@tvogel tvogel commented Oct 16, 2023

TintableIcon.qml: transformOrigin is a FINAL property since Qt 6.6 such that the hiding alias does not work anymore. Instead, use the standard property and tie image.transformOrigin to root.transformOrigin.

TintableIcon.qml: transformOrigin is a FINAL property since Qt 6.6 such
that the hiding alias does not work anymore. Instead, use the standard
property and tie image.transformOrigin to root.transformOrigin.
@misery
Copy link
Contributor

misery commented Oct 17, 2023

Thanks, yes. Here is the patch of next version.

diff --git a/resources/qml/Governikus/Global/+desktop/NavigationButton.qml b/resources/qml/Governikus/Global/+desktop/NavigationButton.qml
--- a/resources/qml/Governikus/Global/+desktop/NavigationButton.qml
+++ b/resources/qml/Governikus/Global/+desktop/NavigationButton.qml
@@ -61,7 +61,6 @@ Button {
                                }
                                sourceSize.height: Style.dimens.large_icon_size
                                tintColor: Style.color.button_text
-                               transformOrigin: Item.Center
                        }
                        GText {
                                anchors.centerIn: parent
diff --git a/resources/qml/Governikus/Global/TintableIcon.qml b/resources/qml/Governikus/Global/TintableIcon.qml
--- a/resources/qml/Governikus/Global/TintableIcon.qml
+++ b/resources/qml/Governikus/Global/TintableIcon.qml
@@ -16,7 +16,6 @@ Item {
        property alias sourceSize: image.sourceSize
        property color tintColor: Style.color.primary_text
        property bool tintEnabled: true
-       property alias transformOrigin: image.transformOrigin
 
        implicitHeight: image.implicitHeight
        implicitWidth: image.implicitWidth
diff --git a/resources/qml/Governikus/Workflow/+mobile/NfcProgressIndicator.qml b/resources/qml/Governikus/Workflow/+mobile/NfcProgressIndicator.qml
--- a/resources/qml/Governikus/Workflow/+mobile/NfcProgressIndicator.qml
+++ b/resources/qml/Governikus/Workflow/+mobile/NfcProgressIndicator.qml
@@ -150,7 +150,6 @@ Item {
                opacity: 0
                source: "qrc:https:///images/ausweis.svg"
                sourceSize.height: phone.height * 0.5
-               transformOrigin: Item.Center
                visible: !phone.tintEnabled
        }
        TintableIcon {
@@ -170,7 +169,6 @@ Item {
                        rotation: card.rotation
                        source: "qrc:https:///images/ausweis_outline.svg"
                        sourceSize.height: card.sourceSize.height
-                       transformOrigin: Item.Center
                        visible: !phone.tintEnabled
                        x: card.x - phone.x
                        y: card.y - phone.y

@misery
Copy link
Contributor

misery commented Nov 6, 2023

Fixed in 2.0.0

@misery misery closed this Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants