Update README.rst #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
misery
requested changes
Aug 7, 2017
README.rst
Outdated
| freizuschalten bzw. den Schlüsselbund freizugeben. | ||
|
|
||
| security unlock-keychain -pPASSWORD ${HOME}/Library/Keychains/login.keychain | ||
|
|
||
| Unter iOS wird die AusweisApp2 mittels XCode gebaut! | ||
| Unter macOS wird die AusweisApp2 mittels XCode gebaut! |
There was a problem hiding this comment.
Vielen Dank!
Könnten Sie das "Unter macOS" eher zu "Für iOS" ändern?
"Unter macOS" ist sonst ein wenig missverständlich, da "für macOS" ohne den XCode-Generator gebaut wird.
Kleinigkeiten: - _Jenkins_ ist ein Produktname, daher solle es nicht _Der Jenkins_ heißen. - _macOS_ wird mit kleinem _m_ geschrieben. - iOS Apps werden unter macOS gebaut, nicht unter iOS
|
Habe ich geändert. |
misery
approved these changes
Aug 7, 2017
|
Danke! Die Änderung wird in der nächsten 1.12.x enthalten sein. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kleinigkeiten: