Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path for loading files when build as an rpm package. #18

Closed
wants to merge 2 commits into from

Conversation

tuxmaster5000
Copy link

  • Load translation from Qt path on Linux(relase build)
  • Load config.json from /usr/share/AusweisApp2 on Linux(relase build)
    Both are needed, to package the app as an rpm package.

- Load config.json from /usr/share/AusweisApp2 on Linux(relase build)
Both are needed, to package the app as an rpm package.
@CLAassistant
Copy link

CLAassistant commented Mar 10, 2019

CLA assistant check
All committers have signed the CLA.

@rmader
Copy link

rmader commented May 14, 2019

Any progress on this? Would love to try this on Fedora. The CI requires the following change:

diff --git a/src/global/FileDestination.h b/src/global/FileDestination.h
index 03c7bd0..63d1cb2 100644
--- a/src/global/FileDestination.h
+++ b/src/global/FileDestination.h
@@ -7,8 +7,8 @@
 #pragma once
 
 #include <QCoreApplication>
-#include <QStringBuilder>
 #include <QLibraryInfo>
+#include <QStringBuilder>
 
 namespace governikus
 {
@@ -43,10 +43,12 @@ class FileDestination
 		{
 			#if defined(Q_OS_LINUX) && defined(QT_NO_DEBUG)
 			if (pFilename == QStringLiteral("translations"))
-				return QLibraryInfo::location(QLibraryInfo::TranslationsPath);	
+			{
+				return QLibraryInfo::location(QLibraryInfo::TranslationsPath);
+			}
 			else
-			#endif	
-				return getPath() % QLatin1Char('/') % pFilename;
+			#endif
+			return getPath() % QLatin1Char('/') % pFilename;
 		}

@misery
Copy link
Contributor

misery commented Jun 3, 2019

Hi!

Thank you very much for your request. Sorry for that big delay.
Your patch has the path hardcoded. That won't work for some distributions. That needs to be adjustable. Also it must be possible to solve our internal development handling.

We already know that problem and we will add a solution for that. But we do not have any ETA for that. An official package for a distribution can fix the problem by a simple patch.

@misery
Copy link
Contributor

misery commented Jan 15, 2020

Thanks for your interest! We fixed that issue in v1.20.0.

@misery misery closed this Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants