Adds LayerConfiguration. #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
loosebazooka
reviewed
Jul 2, 2018
| return this; | ||
| } | ||
|
|
||
| public LayerConfiguration build() { |
There was a problem hiding this comment.
required fields are usually passed into the builder directly.
LayerConfiguration.builder(sourceFiles, destinationOnImage).build()
There was a problem hiding this comment.
so we don't have to check what are required at what aren't
TadCordle
reviewed
Jul 2, 2018
| * @param destinationOnImage Unix-style path to add the source files to in the container image | ||
| * filesystem | ||
| */ | ||
| public LayerConfiguration(List<Path> sourceFiles, String destinationOnImage) { |
There was a problem hiding this comment.
Should we verify that destinationOnImage is a valid Unix-style path?
There was a problem hiding this comment.
That might be more than we want in the constructor. In terms of using this class in a potential future library release, I think having the javadoc state the constraint is good enough rather than adding a hidden check ourselves. An alternative is to just accept a Path and convert it to its Unix string form, but we could think more about that when we do the library.
TadCordle
approved these changes
Jul 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #473
This will be fed into
BuildConfigurationto configure the extra-files layer.