Skip to content

Commit

Permalink
chore(codegen): remove temp output file and update gitignore (#1514)
Browse files Browse the repository at this point in the history
This PR addresses two cleanup items to go along with the Github Action setup:
* Updates .gitignore to ignore the maven wrapper jar
* Removes tmp-generate-one-output at the end of generation script workflow.
  • Loading branch information
emmileaf committed Jan 24, 2023
1 parent 26ff254 commit cfb52f9
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ mail.properties
.settings/
.sts4-cache/

# Ignore to avoid pushing maven wrapper jar as binary artifact
.mvn/wrapper/maven-wrapper.jar

# Because re-configuring the directory in the share plugin leads to side effect we ignore the file
dependency-reduced-pom.xml
.factorypath
Expand Down
1 change: 1 addition & 0 deletions spring-cloud-generator/generate-all.sh
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ while IFS=, read -r library_name googleapis_location coordinates_version googlea
-z $monorepo_commitish 2>&1 | tee tmp-generate-one-output || save_error_info $library_name
set +o pipefail
done <<< $libraries
rm tmp-generate-one-output

echo "run google-java-format on generated code"
cd ../spring-cloud-previews
Expand Down

0 comments on commit cfb52f9

Please sign in to comment.