Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging bucket index_configs documentation fixes #11048

Conversation

jbuck
Copy link
Contributor

@jbuck jbuck commented Jun 26, 2024

  • Fix logging bucket index_configs examples
  • Fix log bucket indexing documentation link

This PR fixes documentation for the various logging bucket resources, specifically the index_config examples. It was incorrectly written as a map in the example, but the attributes documentation and tests show that index_config is a block.
This will close two issues:

Release Note Template for Downstream PRs (will be copied)


@github-actions github-actions bot requested a review from shuyama1 June 26, 2024 01:35
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests service/logging and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Jun 26, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 16 insertions(+), 16 deletions(-))
google-beta provider: Diff ( 4 files changed, 16 insertions(+), 16 deletions(-))

Copy link
Member

@shuyama1 shuyama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants