Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go rewrite - all remaining compute documentation diffs #11046

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

c2thorn
Copy link
Member

@c2thorn c2thorn commented Jun 25, 2024

includes a refresh, so please review the 2nd commit specifically

This will generate changes, but they should be all be non-functional documentation reorders or slight description edits

diffs c2thorn/terraform-provider-google-beta@2b22d46

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 30 files changed, 36 insertions(+), 39 deletions(-))
google-beta provider: Diff ( 30 files changed, 36 insertions(+), 39 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_region_url_map (44 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_url_map" "primary" {
  path_matcher {
    route_rules {
      route_action {
        retry_policy {
          retry_conditions = # value needed
        }
      }
    }
  }
}

Resource: google_compute_url_map (66 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_url_map" "primary" {
  path_matcher {
    route_rules {
      route_action {
        retry_policy {
          retry_conditions = # value needed
        }
      }
    }
  }
}

@c2thorn c2thorn requested a review from zli82016 June 25, 2024 23:50
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 982
Passed tests: 908
Skipped tests: 73
Affected tests: 1

Click here to see the affected service packages
  • beyondcorp
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants