Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify doc for sql_statement in google_dataplex_datascan #11045

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

sushilchaskar28
Copy link
Contributor

@sushilchaskar28 sushilchaskar28 commented Jun 25, 2024

Modify doc for sql_statement in google_dataplex_datascan

Ref: https://source.corp.google.com/piper///depot/google3/google/cloud/dataplex/v1/data_quality.proto;l=526

I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

doc: modified doc for `sql_statement` field in `google_dataplex_datascan` resource

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 88 insertions(+))
google-beta provider: Diff ( 3 files changed, 88 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 30 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 44
Passed tests: 43
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • dataplex

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataplexDatascan_dataplexDatascanFullQualityExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataplexDatascan_dataplexDatascanFullQualityExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 4 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 3 files changed, 4 insertions(+), 4 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 44
Passed tests: 44
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • dataplex

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

@zli82016
Copy link
Member

Feel free to let me know when the PR is ready for review.

@sushilchaskar28
Copy link
Contributor Author

Feel free to let me know when the PR is ready for review.

It's good to go.. Just some minor changes

@zli82016 zli82016 changed the title Add support for data quality SQL Assertion Rule Modify doc for sql_statement in google_dataplex_datascan Jun 26, 2024
@zli82016
Copy link
Member

Feel free to let me know when the PR is ready for review.

It's good to go.. Just some minor changes

Got it. I modified the title and release notes for this PR.

Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zli82016 zli82016 merged commit 299de42 into GoogleCloudPlatform:main Jun 26, 2024
16 checks passed
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants