Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sqlAssertion rule #11043

Merged
merged 3 commits into from
Jun 26, 2024
Merged

Conversation

liaoaohaha
Copy link
Contributor

@liaoaohaha liaoaohaha commented Jun 25, 2024

Add SqlAssertion to Data Quality Scan rules.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

dataplex: added `sql_assertion` field to `google_dataplex_datascan` resource

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@SarahFrench, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Jun 25, 2024
@modular-magician modular-magician added service/dataplex and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Jun 26, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 88 insertions(+))
google-beta provider: Diff ( 3 files changed, 88 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 30 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dataplex_datascan (9 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_datascan" "primary" {
  data_quality_spec {
    rules {
      sql_assertion {
        sql_statement = # value needed
      }
    }
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 44
Passed tests: 43
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • dataplex

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataplexDatascan_dataplexDatascanFullQualityExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDataplexDatascan_dataplexDatascanFullQualityExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

Copy link
Collaborator

@SarahFrench SarahFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi!

I found that a field is misnamed in the file that is used to generated acceptance tests. I'm going to merge a suggested change to fix the field and re-trigger the tests to run. Then I can re-review

@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Jun 26, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 88 insertions(+))
google-beta provider: Diff ( 3 files changed, 88 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 30 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 44
Passed tests: 43
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • dataplex

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataplexDatascan_dataplexDatascanFullQualityExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataplexDatascan_dataplexDatascanFullQualityExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

@SarahFrench SarahFrench merged commit 32ed20c into GoogleCloudPlatform:main Jun 26, 2024
15 checks passed
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jun 28, 2024
pcostell pushed a commit to pcostell/magic-modules that referenced this pull request Jul 16, 2024
vijaykanthm pushed a commit to vijaykanthm/magic-modules that referenced this pull request Jul 22, 2024
Charlesleonius pushed a commit to Charlesleonius/magic-modules that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants