Promote max_run_duration, on_instance_stop_action fields on instance, instance template resources to GA.

[arungantasala]

Background: Support for max_run_duration, on_instance_stop_action in beta has been added in #9313, #10683. These fields were recently promoted to GA.

Also, updated the go.mod according by following these instructions

Release Note Template for Downstream PRs (will be copied)

compute: promoted `max_run_duration`, `on_instance_stop_action` fields on `google_compute_instance`, `google_compute_instance_template`, and `google_compute_instance_from_machine_image ` resources to GA

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 11 files changed, 1055 insertions(+), 142 deletions(-))
google-beta provider: Diff ( 8 files changed, 150 insertions(+), 149 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 8 insertions(+), 6 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 921 insertions(+), 8 deletions(-))
google-beta provider: Diff ( 6 files changed, 16 insertions(+), 15 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 8 insertions(+), 6 deletions(-))

[modular-magician]

Tests analytics

Total tests: 964
Passed tests: 890
Skipped tests: 73
Affected tests: 1

Click here to see the affected service packages

• compute

#### Non-exercised tests

Tests were added that are GA-only additions and require manual runs:

• TestAccComputeInstanceTemplate_maxRunDuration_onInstanceStopAction
• TestAccComputeInstanceTemplate_spot_maxRunDuration
• TestAccComputeInstanceTemplate_spot_maxRunDuration_deleteTerminationAction
• TestAccComputeInstanceTemplate_spot_maxRunDuration_stopTerminationAction
• TestAccComputeInstance_localSsdVM_maxRunDuration_stopTerminationAction
• TestAccComputeInstance_maxRunDuration_update
• TestAccComputeInstance_spotVM_maxRunDuration_deleteTerminationAction
• TestAccComputeInstance_spotVM_maxRunDuration_update
• TestAccComputeInstance_standardVM_maxRunDuration_deleteTerminationAction
• TestAccComputeInstance_standardVM_maxRunDuration_stopTerminationAction
• TestAccComputeRegionInstanceTemplate_maxRunDuration_onInstanceStopAction
• TestAccComputeRegionInstanceTemplate_spot_maxRunDuration

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[arungantasala]

Hi @trodge,
Could you please take a look at this PR? The test failure seems un related. Could you also do a /gcbrun to re-run the tests? Thanks

[github-actions]

@trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[trodge]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 921 insertions(+), 8 deletions(-))
google-beta provider: Diff ( 6 files changed, 16 insertions(+), 15 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 8 insertions(+), 6 deletions(-))

[modular-magician]

Tests analytics

Total tests: 965
Passed tests: 891
Skipped tests: 73
Affected tests: 1

Click here to see the affected service packages

• compute

#### Non-exercised tests

Tests were added that are GA-only additions and require manual runs:

• TestAccComputeInstanceTemplate_maxRunDuration_onInstanceStopAction
• TestAccComputeInstanceTemplate_spot_maxRunDuration
• TestAccComputeInstanceTemplate_spot_maxRunDuration_deleteTerminationAction
• TestAccComputeInstanceTemplate_spot_maxRunDuration_stopTerminationAction
• TestAccComputeInstance_localSsdVM_maxRunDuration_stopTerminationAction
• TestAccComputeInstance_maxRunDuration_update
• TestAccComputeInstance_spotVM_maxRunDuration_deleteTerminationAction
• TestAccComputeInstance_spotVM_maxRunDuration_update
• TestAccComputeInstance_standardVM_maxRunDuration_deleteTerminationAction
• TestAccComputeInstance_standardVM_maxRunDuration_stopTerminationAction
• TestAccComputeRegionInstanceTemplate_maxRunDuration_onInstanceStopAction
• TestAccComputeRegionInstanceTemplate_spot_maxRunDuration

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test