-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added stack_type (enum) and gateway_ip_version (enum) to HAVPN resource #11036
base: main
Are you sure you want to change the base?
Added stack_type (enum) and gateway_ip_version (enum) to HAVPN resource #11036
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_compute_ha_vpn_gateway" "primary" {
gateway_ip_version = # value needed
}
|
Tests analyticsTotal tests: 964 Click here to see the affected service packages
Action takenFound 17 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
name: 'gatewayIpVersion' | ||
description: | | ||
The IP family of the gateway IPs for the HA-VPN gateway interfaces. If not specified, IPV4 will be used. | ||
default_value: :IPV4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with this field having a default value, let's add a test case that ensures that the default value is in fact IPV4
to prevent future changes from breaking the test.
|
Modified the following fields in HA VPN Gateway resource (b/291919420):
Release Note Template for Downstream PRs (will be copied)