Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added stack_type (enum) and gateway_ip_version (enum) to HAVPN resource #11036

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

amanMahendroo
Copy link

@amanMahendroo amanMahendroo commented Jun 25, 2024

Modified the following fields in HA VPN Gateway resource (b/291919420):

  • stack_type (enum): Added option IPV6_ONLY
  • gateway_ip_version (enum): Added new enum field "gateway_ip_version" with possible values IPV4 and IPV6

Release Note Template for Downstream PRs (will be copied)

compute: added `stack_type`, and `gateway_ip_version` fields to `google_compute_router` resource

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Jun 25, 2024
@amanMahendroo amanMahendroo marked this pull request as ready for review June 27, 2024 05:50
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from BBBmau June 27, 2024 05:50
@modular-magician modular-magician added service/compute-vpn and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Jun 27, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 40 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 3 files changed, 40 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_ha_vpn_gateway (28 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_ha_vpn_gateway" "primary" {
  gateway_ip_version = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 964
Passed tests: 874
Skipped tests: 73
Affected tests: 17

Click here to see the affected service packages
  • compute

Action taken

Found 17 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeHaVpnGateway_haVpnGatewayBasicExample
  • TestAccComputeHaVpnGateway_haVpnGatewayIpv6Example
  • TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy
  • TestAccComputeRouterInterface_withTunnel
  • TestAccComputeRouterPeer_AddMd5AuthenticationKey
  • TestAccComputeRouterPeer_EnableDisableIpv6
  • TestAccComputeRouterPeer_Ipv4BasicCreateUpdate
  • TestAccComputeRouterPeer_Ipv6Basic
  • TestAccComputeRouterPeer_UpdateIpv6Address
  • TestAccComputeRouterPeer_UpdateMd5AuthenticationKey
  • TestAccComputeRouterPeer_advertiseMode
  • TestAccComputeRouterPeer_basic
  • TestAccComputeRouterPeer_bfd
  • TestAccComputeRouterPeer_enable
  • TestAccComputeVpnTunnel_router
  • TestAccDataSourceComputeHaVpnGateway
  • TestAccDataSourceComputeRouterStatus

Get to know how VCR tests work

name: 'gatewayIpVersion'
description: |
The IP family of the gateway IPs for the HA-VPN gateway interfaces. If not specified, IPV4 will be used.
default_value: :IPV4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with this field having a default value, let's add a test case that ensures that the default value is in fact IPV4 to prevent future changes from breaking the test.

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeHaVpnGateway_haVpnGatewayBasicExample[Debug log]
TestAccComputeHaVpnGateway_haVpnGatewayIpv6Example[Debug log]
TestAccComputeRouterInterface_withTunnel[Debug log]
TestAccComputeRouterPeer_AddMd5AuthenticationKey[Debug log]
TestAccComputeRouterPeer_EnableDisableIpv6[Debug log]
TestAccComputeRouterPeer_Ipv4BasicCreateUpdate[Debug log]
TestAccComputeRouterPeer_Ipv6Basic[Debug log]
TestAccComputeRouterPeer_UpdateIpv6Address[Debug log]
TestAccComputeRouterPeer_UpdateMd5AuthenticationKey[Debug log]
TestAccComputeRouterPeer_advertiseMode[Debug log]
TestAccComputeRouterPeer_basic[Debug log]
TestAccComputeRouterPeer_bfd[Debug log]
TestAccComputeRouterPeer_enable[Debug log]
TestAccComputeVpnTunnel_router[Debug log]
TestAccDataSourceComputeHaVpnGateway[Debug log]
TestAccDataSourceComputeRouterStatus[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants