Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New data source for google_gke_hub_membership_binding #11032

Merged
merged 76 commits into from
Jul 9, 2024

Conversation

sahsagar-google
Copy link
Member

@sahsagar-google sahsagar-google commented Jun 24, 2024

Fixes hashicorp/terraform-provider-google#18538

Release Note Template for Downstream PRs (will be copied)

`google_gke_hub_membership_binding`

sahsagar-google and others added 30 commits July 19, 2023 19:04
@github-actions github-actions bot requested a review from shuyama1 July 2, 2024 19:55
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 165 insertions(+))
google-beta provider: Diff ( 3 files changed, 165 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 24
Passed tests: 13
Skipped tests: 10
Affected tests: 1

Click here to see the affected service packages
  • gkehub2

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataSourceGoogleGKEHub2MembershipBinding_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceGoogleGKEHub2MembershipBinding_basic[Debug log]
$\textcolor{red}{\textsf{Tests failed when rerunning REPLAYING mode:}}$
TestAccDataSourceGoogleGKEHub2MembershipBinding_basic[Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 151 insertions(+))
google-beta provider: Diff ( 3 files changed, 151 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 24
Passed tests: 13
Skipped tests: 10
Affected tests: 1

Click here to see the affected service packages
  • gkehub2

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataSourceGoogleGKEHub2MembershipBinding_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDataSourceGoogleGKEHub2MembershipBinding_basic[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

The service anthos.googleapis.com is depended on by active edgecontainer service hence disabling its destroy
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 152 insertions(+))
google-beta provider: Diff ( 3 files changed, 152 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 24
Passed tests: 13
Skipped tests: 10
Affected tests: 1

Click here to see the affected service packages
  • gkehub2

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataSourceGoogleGKEHub2MembershipBinding_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceGoogleGKEHub2MembershipBinding_basic[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

Copy link
Member

@shuyama1 shuyama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, only one small comment regarding the test

Removing service enablement as the services might already be enabled in the test project
@github-actions github-actions bot requested a review from shuyama1 July 3, 2024 16:58
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 128 insertions(+))
google-beta provider: Diff ( 3 files changed, 128 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 24
Passed tests: 13
Skipped tests: 10
Affected tests: 1

Click here to see the affected service packages
  • gkehub2

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataSourceGoogleGKEHub2MembershipBinding_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDataSourceGoogleGKEHub2MembershipBinding_basic[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 126 insertions(+))
google-beta provider: Diff ( 3 files changed, 126 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 24
Passed tests: 14
Skipped tests: 10
Affected tests: 0

Click here to see the affected service packages
  • gkehub2

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

Copy link

github-actions bot commented Jul 8, 2024

@shuyama1 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Member

@shuyama1 shuyama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants