-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New data source for google_gke_hub_membership_binding #11032
Conversation
…hings simpler in the review
…h the one from test env
Tests analyticsTotal tests: 24 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made. Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer. |
Removing project creation
Tests analyticsTotal tests: 24 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
The service anthos.googleapis.com is depended on by active edgecontainer service hence disabling its destroy
Tests analyticsTotal tests: 24 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, only one small comment regarding the test
...third_party/terraform/services/gkehub2/data_source_google_gke_hub_membership_binding_test.go
Outdated
Show resolved
Hide resolved
Removing service enablement as the services might already be enabled in the test project
Tests analyticsTotal tests: 24 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
Removing lingering wait on enablement
Tests analyticsTotal tests: 24 Click here to see the affected service packages
View the build log |
@shuyama1 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
Fixes hashicorp/terraform-provider-google#18538
Release Note Template for Downstream PRs (will be copied)