-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added missing changes to "compute_security_policy" contribution docs #11024
Added missing changes to "compute_security_policy" contribution docs #11024
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one small change request.
* `TLS_JA3_FINGERPRINT`: -- JA3 TLS/SSL fingerprint if the client connects using HTTPS, HTTP/2 or HTTP/3. If not available, the key type defaults to ALL. | ||
* `USER_IP`: -- The IP address of the originating client, which is resolved based on "userIpRequestHeaders" configured with the securitypolicy. If there is no "userIpRequestHeaders" configuration or an IP address cannot be resolved from it, the key type defaults to IP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* `TLS_JA3_FINGERPRINT`: -- JA3 TLS/SSL fingerprint if the client connects using HTTPS, HTTP/2 or HTTP/3. If not available, the key type defaults to ALL. | |
* `USER_IP`: -- The IP address of the originating client, which is resolved based on "userIpRequestHeaders" configured with the securitypolicy. If there is no "userIpRequestHeaders" configuration or an IP address cannot be resolved from it, the key type defaults to IP. | |
* `TLS_JA3_FINGERPRINT`: JA3 TLS/SSL fingerprint if the client connects using HTTPS, HTTP/2 or HTTP/3. If not available, the key type defaults to ALL. | |
* `USER_IP`: The IP address of the originating client, which is resolved based on "user_ip_request_headers" configured with the securitypolicy. If there is no "user_ip_request_headers" configuration or an IP address cannot be resolved from it, the key type defaults to IP. |
* `TLS_JA3_FINGERPRINT`: -- JA3 TLS/SSL fingerprint if the client connects using HTTPS, HTTP/2 or HTTP/3. If not available, the key type defaults to ALL. | ||
* `USER_IP`: -- The IP address of the originating client, which is resolved based on "userIpRequestHeaders" configured with the securitypolicy. If there is no "userIpRequestHeaders" configuration or an IP address cannot be resolved from it, the key type defaults to IP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* `TLS_JA3_FINGERPRINT`: -- JA3 TLS/SSL fingerprint if the client connects using HTTPS, HTTP/2 or HTTP/3. If not available, the key type defaults to ALL. | |
* `USER_IP`: -- The IP address of the originating client, which is resolved based on "userIpRequestHeaders" configured with the securitypolicy. If there is no "userIpRequestHeaders" configuration or an IP address cannot be resolved from it, the key type defaults to IP. | |
* `TLS_JA3_FINGERPRINT`: JA3 TLS/SSL fingerprint if the client connects using HTTPS, HTTP/2 or HTTP/3. If not available, the key type defaults to ALL. | |
* `USER_IP`: The IP address of the originating client, which is resolved based on "user_ip_request_headers" configured with the securitypolicy. If there is no "user_ip_request_headers" configuration or an IP address cannot be resolved from it, the key type defaults to IP. |
please also fix the changelog-checker failure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll go ahead and make this commit since it was fine to do in the other spot.
mmv1/third_party/terraform/website/docs/r/compute_security_policy.html.markdown
Outdated
Show resolved
Hide resolved
…icy.html.markdown
This comment was marked as outdated.
This comment was marked as outdated.
…oogleCloudPlatform#11024) Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
…oogleCloudPlatform#11024) Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
…oogleCloudPlatform#11024) Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
…oogleCloudPlatform#11024) Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
Updates the documentation of the handwritten resource, adding the changes that were not documented in the following PR's:
#10761
#10596
Release Note Template for Downstream PRs (will be copied)