Update the descriptions for sql_database_instance disk_size and disk_autoresize #11005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In admin API, we don't have validation for host of on-premise instances. Host can take the value of IP address or DNS address. As of now it is validating that host contain the IP address in terraform, in order to be consistent with admin API and accept DNS address as well, removing the validation function for host.
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
modular-magician
added
the
awaiting-approval
|
@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
rileykarson
reviewed
Jun 25, 2024
| @@ -292,11 +292,11 @@ The `settings` block supports: | |||
|
|
|||
| * `enable_google_ml_integration` - (Optional) Enables [Cloud SQL instances to connect to Vertex AI](https://cloud.google.com/sql/docs/postgres/integrate-cloud-sql-with-vertex-ai) and pass requests for real-time predictions and insights. Defaults to `false`. | |||
|
|
|||
| * `disk_autoresize` - (Optional) Enables auto-resizing of the storage size. Defaults to `true`. | |||
| * `disk_autoresize` - (Optional) Enables auto-resizing of the storage size. Defaults to `true`. Note that future terraform apply calls will attempt to delete the instance in order to resize the disk to the value specified in disk_size. | |||
There was a problem hiding this comment.
Suggested change
| * `disk_autoresize` - (Optional) Enables auto-resizing of the storage size. Defaults to `true`. Note that future terraform apply calls will attempt to delete the instance in order to resize the disk to the value specified in disk_size. | |
| * `disk_autoresize` - (Optional) Enables auto-resizing of the storage size. Defaults to `true`. Note that if `disk_size` is set, future `terraform apply` calls will attempt to delete the instance in order to resize the disk to the value specified in disk_size if it has been resized. To avoid this, ensure that `lifecycle.ignore_changes` is applied to `disk_size`. |
|
|
||
| * `disk_autoresize_limit` - (Optional) The maximum size to which storage capacity can be automatically increased. The default value is 0, which specifies that there is no limit. | ||
|
|
||
| * `disk_size` - (Optional) The size of data disk, in GB. Size of a running instance cannot be reduced but can be increased. The minimum value is 10GB. | ||
| * `disk_size` - (Optional) The size of data disk, in GB. Size of a running instance cannot be reduced but can be increased. The minimum value is 10GB. Note that future terraform apply calls will attempt to delete the instance in order to expand the instance if disk_autoresize is true. |
There was a problem hiding this comment.
Suggested change
| * `disk_size` - (Optional) The size of data disk, in GB. Size of a running instance cannot be reduced but can be increased. The minimum value is 10GB. Note that future terraform apply calls will attempt to delete the instance in order to expand the instance if disk_autoresize is true. | |
| * `disk_size` - (Optional) The size of data disk, in GB. Size of a running instance cannot be reduced but can be increased. The minimum value is 10GB. Note that this value will override the resizing from `disk_autoresize` if that feature is enabled. To avoid this, set `lifecycle.ignore_changes` on this field. |
|
@jharshika, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required. If no action is taken, this PR will be closed in 28 days. This notification can be disabled with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a warning in sql_database_instance#disk_size documentation as requested in hashicorp/terraform-provider-google#9845.
Under default configuration i.e. disk_autoresize set to true, setting the value for disk_size will delete the instance to automatically expand the disk. Added a warning for the customers about this in the fields disk_autoresize and disk_size.
Release Note Template for Downstream PRs (will be copied)