Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Resource SCC V1 Project Notification Config #11004

Conversation

vijaykanthm
Copy link
Contributor

@vijaykanthm vijaykanthm commented Jun 19, 2024

Related to http:https://b/309603080.

Bug Description: hashicorp/terraform-provider-google#16427

Adding new template for SCC API V1 Project Notification Config
https://cloud.google.com/security-command-center/docs/reference/rest/v1/projects.notificationConfigs

Release Note Template for Downstream PRs (will be copied)

`google_scc_project_notification_config`

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from c2thorn June 19, 2024 18:58
@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests service/securitycenter and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Jun 19, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 969 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 969 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 108 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_scc_project_notification_config (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_scc_project_notification_config" "primary" {
  project_id = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • securitycenter

Non-exercised tests

Tests were added that are skipped in VCR:

  • TestAccSecurityCenterProjectNotificationConfig_sccProjectNotificationConfigBasicExample
  • TestAccSecurityCenterProjectNotificationConfig_updateStreamingConfigFilter

$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$
View the build log

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Jun 24, 2024
Copy link

@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@modular-magician modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Jun 24, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 969 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 969 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 108 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 24
Passed tests: 11
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • securitycenter

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSecurityCenterProjectNotificationConfig_sccProjectNotificationConfigBasicExample
  • TestAccSecurityCenterProjectNotificationConfig_updateStreamingConfigFilter

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccSecurityCenterProjectNotificationConfig_sccProjectNotificationConfigBasicExample[Error message] [Debug log]
TestAccSecurityCenterProjectNotificationConfig_updateStreamingConfigFilter[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Jun 26, 2024
Copy link

@GoogleCloudPlatform/terraform-team @c2thorn This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

triggered build

@modular-magician modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Jun 26, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1017 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1017 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 108 insertions(+))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • securitycenter
#### Non-exercised tests

Tests were added that are skipped in VCR:

  • TestAccSecurityCenterProjectNotificationConfig_sccProjectNotificationConfigBasicExample
  • TestAccSecurityCenterProjectNotificationConfig_updateStreamingConfigFilter
    $\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$

View the build log

@github-actions github-actions bot requested a review from c2thorn June 28, 2024 02:53
@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Jun 28, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1005 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1005 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 108 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 13
Passed tests: 11
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • securitycenter

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSecurityCenterProjectNotificationConfig_sccProjectNotificationConfigBasicExample
  • TestAccSecurityCenterProjectNotificationConfig_updateStreamingConfigFilter

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccSecurityCenterProjectNotificationConfig_sccProjectNotificationConfigBasicExample[Error message] [Debug log]
TestAccSecurityCenterProjectNotificationConfig_updateStreamingConfigFilter[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

        Error: Unsupported argument
        
          on terraform_plugin_test.tf line 8, in resource "google_scc_project_notification_config" "custom_notification_config":
           8:   project_id   = ""

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 13
Passed tests: 11
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • securitycenter

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSecurityCenterProjectNotificationConfig_sccProjectNotificationConfigBasicExample
  • TestAccSecurityCenterProjectNotificationConfig_updateStreamingConfigFilter

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccSecurityCenterProjectNotificationConfig_updateStreamingConfigFilter[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccSecurityCenterProjectNotificationConfig_sccProjectNotificationConfigBasicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

Copy link

github-actions bot commented Jul 4, 2024

@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link

github-actions bot commented Jul 8, 2024

@GoogleCloudPlatform/terraform-team @c2thorn This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

    vcr_utils.go:152: Step 2/2 error running import: ImportStateVerify attributes not equivalent. Difference is shown below. The - symbol indicates attributes missing after import.
        
        Â Â map[string]string{
        -Â 	"project": "<redacted id>",
        +Â 	"project": "<redacted num>",
        Â Â }

probably need to add project to ignore_read_extra in the example

@github-actions github-actions bot requested a review from c2thorn July 8, 2024 19:00
@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Jul 8, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1007 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1007 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 108 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • securitycenter
#### Non-exercised tests

Tests were added that are skipped in VCR:

  • TestAccSecurityCenterProjectNotificationConfig_sccProjectNotificationConfigBasicExample
  • TestAccSecurityCenterProjectNotificationConfig_updateStreamingConfigFilter
    $\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$

View the build log

@github-actions github-actions bot requested a review from c2thorn July 8, 2024 22:00
@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Jul 8, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1005 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1005 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 108 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 13
Passed tests: 12
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • securitycenter

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSecurityCenterProjectNotificationConfig_sccProjectNotificationConfigBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccSecurityCenterProjectNotificationConfig_sccProjectNotificationConfigBasicExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Jul 9, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1005 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1005 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 108 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 13
Passed tests: 13
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • securitycenter

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants