Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jobset and kueue manifests for "Orchestrating TPU MultiSlice workloads using JobSet and Kueue" public docs #1165

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

danielvegamyhre
Copy link

Description

The purpose of these changes is to add the k8s manifests corresponding to our guide in the public docs on Orchestrating TPU MultiSlice workloads using JobSet and Kueue.

Tasks

  • The contributing guide has been read and followed.
  • The samples added / modified have been fully tested.
  • Workflow files have been added / modified, if applicable.
  • Region tags have been properly added, if new samples.
  • All dependencies are set to up-to-date versions, as applicable.

@danielvegamyhre danielvegamyhre changed the title add jobset and kueue manifests for public docs Add jobset and kueue manifests for "Orchestrating TPU MultiSlice workloads using JobSet and Kueue" public docs Feb 27, 2024
@bourgeoisor
Copy link
Member

@danielvegamyhre all new open source files require this copyright header at the top:

# Copyright 2024 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
#      https://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

@danielvegamyhre
Copy link
Author

@danielvegamyhre all new open source files require this copyright header at the top:

# Copyright 2024 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
#      https://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

Added

Copy link
Member

@bourgeoisor bourgeoisor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just missing two things and then it looks good:

  1. A /batch/jobset/tpu-multislice/README.md file with the link of the tutorial (you can start from this example: https://github.com/GoogleCloudPlatform/kubernetes-engine-samples/blob/main/ai-ml/llm-multiple-gpus/README.md)

  2. Unique region tags surrounding the three files, with the prefix gke_batch_jobset_tpu_multislice_ (You can see an example here: https://github.com/GoogleCloudPlatform/kubernetes-engine-samples/blob/main/ai-ml/gke-ray/rayserve/gradio.yaml#L15)

@bourgeoisor
Copy link
Member

@danielvegamyhre gentle ping!

@danielvegamyhre
Copy link
Author

@bourgeoisor I am still working on this, I've just had to focus on higher priority work lately.

@bourgeoisor
Copy link
Member

@danielvegamyhre no rush or anything, just making sure it doesn't fall through the cracks :)

@NimJay NimJay marked this pull request as draft August 15, 2024 18:42
@NimJay
Copy link
Collaborator

NimJay commented Aug 15, 2024

Hi @danielvegamyhre, again, no rush at all (take your time!) — just FYI: @bourgeoisor no longer works on this GitHub repository.
So when this pull-request is ready for review, please tag me (@NimJay).
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants