Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cleanup): remove internal client library code as it is now publ… #4213

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

luongadam
Copy link
Contributor

…ished to package managers

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • [n/a] These samples need a new API enabled in testing projects to pass (let us know which ones)
  • [n/a] These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • [n/a] This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • [n/a] This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@luongadam luongadam requested review from a team as code owners June 25, 2024 20:46
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jun 25, 2024
@hongalex hongalex added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 25, 2024
@hongalex hongalex enabled auto-merge (squash) June 25, 2024 21:55
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 25, 2024
@luongadam
Copy link
Contributor Author

Glanced through the Kokoro build logs and couldn't find any errors pertaining to this PR. I noticed other tests outside of our service were failing due to permission denied issues so maybe that is the cause.

@hongalex Do you think we should trigger another run?

@hongalex hongalex added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Jun 26, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 26, 2024
@hongalex hongalex merged commit e617957 into GoogleCloudPlatform:main Jun 26, 2024
9 checks passed
@luongadam luongadam deleted the remove-internal branch June 26, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants