Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compute): hyperdisk_create/hyperdisk_pool_create/hyperdisk_create_from_pool samples #4191

Merged
merged 12 commits into from
Jul 6, 2024

Conversation

irudykss
Copy link
Contributor

…e_from_pool samples

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added api: compute Issues related to the Compute Engine API. samples Issues that are directly related to samples. labels Jun 17, 2024
@irudykss irudykss requested a review from muncus June 17, 2024 09:53
@irudykss irudykss marked this pull request as ready for review June 18, 2024 07:46
@irudykss irudykss requested review from a team as code owners June 18, 2024 07:46
Copy link

snippet-bot bot commented Jun 18, 2024

Here is the summary of changes.

You are about to add 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@irudykss irudykss added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 18, 2024
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 18, 2024
compute/disks/create_hyperdisk.go Outdated Show resolved Hide resolved
compute/disks/create_hyperdisk.go Outdated Show resolved Hide resolved
compute/disks/create_hyperdisk_from_pool.go Outdated Show resolved Hide resolved
compute/disks/create_hyperdisk_from_pool.go Outdated Show resolved Hide resolved
compute/disks/create_hyperdisk_pool.go Outdated Show resolved Hide resolved
compute/disks/create_hyperdisk_pool.go Outdated Show resolved Hide resolved
compute/disks/disks_test.go Show resolved Hide resolved
compute/disks/disks_test.go Outdated Show resolved Hide resolved
compute/disks/disks_test.go Outdated Show resolved Hide resolved
compute/disks/disks_test.go Show resolved Hide resolved
@BigBlackWolf BigBlackWolf requested a review from a team as a code owner June 26, 2024 11:04
@BigBlackWolf BigBlackWolf added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Jun 26, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 27, 2024
@BigBlackWolf BigBlackWolf removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 1, 2024
@BigBlackWolf BigBlackWolf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 1, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 1, 2024
@BigBlackWolf BigBlackWolf requested a review from muncus July 1, 2024 13:41
muncus
muncus previously requested changes Jul 3, 2024
compute/disks/create_hyperdisk_from_pool.go Outdated Show resolved Hide resolved
compute/disks/disks_test.go Show resolved Hide resolved
@BigBlackWolf BigBlackWolf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 4, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 4, 2024
@BigBlackWolf BigBlackWolf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 4, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 4, 2024
@m-strzelczyk m-strzelczyk requested a review from muncus July 4, 2024 14:55
@BigBlackWolf BigBlackWolf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 5, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 5, 2024
@BigBlackWolf BigBlackWolf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 5, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 5, 2024
@BigBlackWolf BigBlackWolf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 5, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 5, 2024
@BigBlackWolf BigBlackWolf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 5, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 5, 2024
@BigBlackWolf BigBlackWolf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 5, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 5, 2024
@BigBlackWolf BigBlackWolf dismissed muncus’s stale review July 6, 2024 07:27

Adjusted in separate commit

@BigBlackWolf BigBlackWolf merged commit 4807209 into main Jul 6, 2024
11 checks passed
@BigBlackWolf BigBlackWolf deleted the samples/hyperdisk branch July 6, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: compute Issues related to the Compute Engine API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants