Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate image sample #4185

Merged
merged 3 commits into from
Jun 28, 2024
Merged

Conversation

BigBlackWolf
Copy link
Collaborator

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@BigBlackWolf BigBlackWolf requested review from a team as code owners June 13, 2024 09:16
Copy link

snippet-bot bot commented Jun 13, 2024

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jun 13, 2024
@BigBlackWolf BigBlackWolf force-pushed the compute_images_set_deprecation_status branch from 36de1ea to 777c596 Compare June 13, 2024 09:20
@BigBlackWolf BigBlackWolf added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 13, 2024
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 13, 2024
@BigBlackWolf BigBlackWolf added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Jun 14, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 14, 2024
@BigBlackWolf BigBlackWolf self-assigned this Jun 14, 2024
@BigBlackWolf BigBlackWolf requested a review from muncus June 14, 2024 17:27
muncus
muncus previously requested changes Jun 20, 2024
compute/disk-images/deprecate_disk_image.go Outdated Show resolved Hide resolved
@BigBlackWolf BigBlackWolf added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 22, 2024
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 22, 2024
@BigBlackWolf BigBlackWolf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 24, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 24, 2024
@BigBlackWolf BigBlackWolf requested a review from muncus June 24, 2024 11:56
@BigBlackWolf BigBlackWolf enabled auto-merge (squash) June 27, 2024 10:45
@BigBlackWolf BigBlackWolf requested a review from a team as a code owner June 28, 2024 11:45
@BigBlackWolf BigBlackWolf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 28, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 28, 2024
@BigBlackWolf BigBlackWolf dismissed muncus’s stale review June 28, 2024 14:03

fixed in separate commit

@BigBlackWolf BigBlackWolf merged commit b8aac05 into main Jun 28, 2024
11 checks passed
@BigBlackWolf BigBlackWolf deleted the compute_images_set_deprecation_status branch June 28, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants